Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add codeowners for data platform resources [UA-9391] #862

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat: add codeowners for data platform resources [UA-9391] #862

merged 1 commit into from
Sep 27, 2024

Conversation

mpayne-coveo
Copy link
Contributor

Adds codeowners for resources owned by data platform (specifically the UI subset of owners).

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@mpayne-coveo mpayne-coveo marked this pull request as ready for review September 25, 2024 17:38
@mpayne-coveo mpayne-coveo requested review from a team as code owners September 25, 2024 17:38
@mpayne-coveo mpayne-coveo added this pull request to the merge queue Sep 27, 2024
Merged via the queue into master with commit 729492b Sep 27, 2024
5 checks passed
@mpayne-coveo mpayne-coveo deleted the feat/UA-9391_add_dpf_codeowners branch September 27, 2024 12:57
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 55.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme approved these changes

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@gdostie gdostie Awaiting requested review from gdostie gdostie is a code owner automatically assigned from coveo/frontend-foundation

@aboissinot-coveo aboissinot-coveo Awaiting requested review from aboissinot-coveo aboissinot-coveo is a code owner automatically assigned from coveo/frontend-foundation

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpayne-coveo @fbeaudoincoveo @alexprudhomme