clean controller build condition

packages/headless/src/app/commerce-ssr-engine/common.ts

@@ -80,34 +80,17 @@ export function buildControllerDefinitions<
   TSolutionType
 > {
   const controllerMap = mapObject(definitionsMap, (definition, key) => {
-    const unavailableInSearchSolutionType =
-      'search' in definition &&
-      definition['search'] === false &&
-      solutionType === SolutionType['search'];
-
-    const unavailableInListingSolutionType =
-      'listing' in definition &&
-      definition['listing'] === false &&
-      solutionType === SolutionType['listing'];
-
-    const unavailableInStandaloneSolutionType =
-      solutionType === SolutionType['standalone'] && 'standalone' in definition
-        ? definition['standalone'] === false
-        : false;
-
-    const unavailabeInRecs =
-      // TODO: use this disjunction pattern for all other conditions
-      (solutionType === SolutionType['recommendation'] &&
-        !('recommendation' in definition)) ||
-      ('recommendation' in definition &&
-        definition['recommendation'] === false &&
-        solutionType === SolutionType['recommendation']);
+    const unavailableInSolutionType = (type: SolutionType) =>
+      (!(type in definition) && solutionType === SolutionType[type]) ||
+      (type in definition &&
+        definition[type as keyof typeof definition] === false &&
+        solutionType === SolutionType[type]);
 
     if (
-      unavailableInSearchSolutionType ||
-      unavailableInListingSolutionType ||
-      unavailableInStandaloneSolutionType ||
-      unavailabeInRecs
+      unavailableInSolutionType(SolutionType.search) ||
+      unavailableInSolutionType(SolutionType.listing) ||
+      unavailableInSolutionType(SolutionType.standalone) ||
+      unavailableInSolutionType(SolutionType.recommendation)
     ) {
       return null;
     }

packages/headless/src/app/commerce-ssr-engine/factories/recommendation-static-state-factory.ts

@@ -115,7 +115,7 @@ function filterRecommendationControllers<
   TEngine extends CoreEngine | CoreEngineNext,
   TControllerDefinitions extends ControllerDefinitionsMap<TEngine, Controller>,
 >(
-  controllers: Record<string, Controller>, // TODO: or  InferControllersMapFromDefinition<TControllerDefinitions, SolutionType>
+  controllers: Record<string, Controller>,
   controllerDefinitions: TControllerDefinitions,
   logger: Logger
 ) {

packages/headless/src/controllers/commerce/core/breadcrumb-manager/headless-core-breadcrumb-manager.ssr.ts

@@ -25,6 +25,8 @@ export function defineBreadcrumbManager<
 >(options?: TOptions) {
   ensureAtLeastOneSolutionType(options);
   return {
+    listing: true,
+    search: true,
     ...options,
     build: (engine, solutionType) =>
       solutionType === SolutionType.listing

packages/headless/src/controllers/commerce/core/facets/generator/headless-commerce-facet-generator.ssr.ts

@@ -113,6 +113,8 @@ export function defineFacetGenerator<
 >(options?: TOptions) {
   ensureAtLeastOneSolutionType(options);
   return {
+    listing: true,
+    search: true,
     ...options,
     build: (engine, solutionType) =>
       buildFacetGenerator(engine, {props: {solutionType: solutionType!}}),

packages/headless/src/controllers/commerce/core/pagination/headless-core-commerce-pagination.ssr.ts

@@ -28,6 +28,8 @@ export function definePagination<
 >(props?: PaginationProps & TOptions) {
   ensureAtLeastOneSolutionType(props);
   return {
+    listing: true,
+    search: true,
     ...props,
     build: (engine, solutionType) =>
       solutionType === SolutionType.listing

packages/headless/src/controllers/commerce/core/parameter-manager/headless-core-parameter-manager.ssr.ts

@@ -46,6 +46,8 @@ export function defineParameterManager<
 >(options?: TOptions) {
   ensureAtLeastOneSolutionType(options);
   return {
+    listing: true,
+    search: true,
     ...options,
     buildWithProps: (engine, props, solutionType) => {
       if (solutionType === SolutionType.listing) {

packages/headless/src/controllers/commerce/core/sort/headless-core-commerce-sort.ssr.ts

@@ -24,6 +24,8 @@ export function defineSort<
 >(props?: SortProps & TOptions) {
   ensureAtLeastOneSolutionType(props);
   return {
+    listing: true,
+    search: true,
     ...props,
     build: (engine, solutionType) =>
       solutionType === SolutionType.listing

packages/headless/src/controllers/commerce/core/sub-controller/headless-sub-controller.ssr.ts

@@ -17,6 +17,8 @@ export function defineQuerySummary<
 >(options?: TOptions) {
   ensureAtLeastOneSolutionType(options);
   return {
+    listing: true,
+    search: true,
     ...options,
     build: (engine, solutionType) =>
       solutionType === SolutionType.listing

packages/headless/src/controllers/commerce/core/summary/headless-core-summary.ssr.ts

@@ -32,6 +32,8 @@ export function defineSummary<
 >(options?: TOptions) {
   ensureAtLeastOneSolutionType(options);
   return {
+    listing: true,
+    search: true,
     ...options,
     build: (engine, solutionType) =>
       solutionType === SolutionType.listing

packages/headless/src/controllers/commerce/product-list/headless-product-list.ssr.ts

@@ -29,6 +29,8 @@ export function defineProductList<
 >(options?: TOptions) {
   ensureAtLeastOneSolutionType(options);
   return {
+    listing: true,
+    search: true,
     ...options,
     build: (engine, solutionType) =>
       solutionType === SolutionType.listing