Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(headless): make CommerceEngineDefinitionOptions an optional generic type #4703

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Nov 22, 2024

https://coveord.atlassian.net/browse/KIT-3713

The goal of this is for the implementer to not have to interact with the ControllerDefinitionsMap & the Controller interface. These are internal and bring more complexity to the implementer than anything else. We can't simply remove that generic since it is used in headless-react for inference but we can make it optional.

turns out this easier than I thought 😅. I did not think of simply making it optional

@alexprudhomme alexprudhomme requested review from a team as code owners November 22, 2024 20:56
@alexprudhomme alexprudhomme changed the title fix(headless): make CommerceEngineDefinitionOptions an optional generic type fix(headless): make CommerceEngineDefinitionOptions an optional generic type Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 242.6 242.6 0
commerce 347.3 347.3 0
search 413.8 413.8 0
insight 404.9 404.9 0
recommendation 254.9 254.9 0
ssr 407.3 407.3 0
ssr-commerce 362.3 362.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 26, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Nov 26, 2024
Merged via the queue into master with commit 0768ce7 Nov 26, 2024
122 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3713 branch November 26, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants