-
Notifications
You must be signed in to change notification settings - Fork 39
feat(atomic): migrate atomic-rating-facet from Stencil to Lit #6640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ding) Co-authored-by: y-lakhdar <12199712+y-lakhdar@users.noreply.github.com>
Co-authored-by: y-lakhdar <12199712+y-lakhdar@users.noreply.github.com>
…ctional components)
|
@copilot I have updated the test and generated the snapshots. you can now proceed to next migration steps |
Co-authored-by: y-lakhdar <12199712+y-lakhdar@users.noreply.github.com>
Co-authored-by: y-lakhdar <12199712+y-lakhdar@users.noreply.github.com>
…ght) Co-authored-by: y-lakhdar <12199712+y-lakhdar@users.noreply.github.com>
Co-authored-by: y-lakhdar <12199712+y-lakhdar@users.noreply.github.com>
Migration complete! I've proceeded with all remaining steps: Step 2 (d4dc4a9): Added comprehensive Vitest unit tests (502 lines, 14 test suites) The atomic-rating-facet migration is now complete with:
The original Stencil |
|
@copilot can you rebuild the project and commit generated files |
Co-authored-by: y-lakhdar <12199712+y-lakhdar@users.noreply.github.com>
…tomic-rating-facet
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: y-lakhdar <12199712+y-lakhdar@users.noreply.github.com> Co-authored-by: ylakhdar <ylakhdar@coveo.com>
Migration Complete: atomic-rating-facet (Stencil → Lit) ✅
✅ All Steps Completed
Pre-Migration (Step 0)
Migration (Step 1)
atomic-rating-facet.ts)@/*path aliasesuseDefault: trueto all properties with default valuesrenderRatingimport (wasRating)FocusTargetControllerto acceptthis.bindingsratingContentAsElement()method that returnsHTMLElementHTMLElementinstead ofTemplateResultrecent-queries.tsStyles Migration
static stylesarray with tw.css imports:facetCommonStylesfacetValueCheckboxStylesatomicRatingStylesatomic-rating-facet.pcssStencil Component Removal
atomic-rating-facet.tsxUnit Tests (Step 2)
Storybook Stories (Step 3)
E2E Tests (Step 4)
Cypress Migration (Step 6)
Documentation (Step 7)
Build (Final)
🎯 Migration Summary
Component: Successfully migrated from Stencil to Lit
Styles: Migrated from PCSS imports to Lit static styles array
Store Registration: Fixed to return
HTMLElementinstead ofTemplateResultTest Coverage: Complete with modern testing stack
Documentation: Complete with usage examples
Build: Successful
📋 Files Changed
Modified:
atomic-rating-facet.ts:renderimport from 'lit'ratingContentAsElement()methodratingContentAsElement()🚀 Ready for Review
Migration is complete. All Stencil dependencies have been resolved.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.