Skip to content

Conversation

@y-lakhdar
Copy link
Contributor

The previous agent created the tests for the snapshots but never ran the tests

Copilot AI review requested due to automatic review settings November 25, 2025 18:12
@y-lakhdar y-lakhdar requested a review from a team as a code owner November 25, 2025 18:12
Copilot finished reviewing on behalf of y-lakhdar November 25, 2025 18:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the Stencil-to-Lit migration agent documentation by making the visual regression testing workflow more explicit and actionable. The update addresses an issue where the agent would create visual tests but fail to actually run them and verify the results before proceeding with migration.

Key changes:

  • Restructured Step 0 with explicit sub-steps (build, generate, verify, commit) to ensure snapshots are actually created and committed before migration
  • Added verification commands and checkpoints to confirm snapshots exist and are included in git commits
  • Enhanced instructions to update page object imports from base-page-object to lit-base-page-object during migration
  • Removed redundant "What's New in V2" section while preserving all critical information in detailed workflow sections

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +225 to 231
```bash
# Stage all E2E files including snapshots
git add packages/atomic/src/components/**/e2e/

# Commit with descriptive message
git commit -m "test: add visual regression tests and baseline snapshots for <component-name> (Stencil)"
```
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent working directory assumption. In Step 0.4 (line 190), the instructions say cd packages/atomic, and Step 0.5 uses a relative path (src/components/**/e2e/__snapshots__/*.png), implying the user is still in the packages/atomic directory. However, this step uses an absolute path from the repository root (packages/atomic/src/components/**/e2e/).

Either:

  1. Use src/components/**/e2e/ (relative to packages/atomic)
  2. Or add a command to return to repository root first: cd ../..

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants