-
Notifications
You must be signed in to change notification settings - Fork 39
chore(ci): update lit migration agent (v2) #6642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the Stencil-to-Lit migration agent documentation by making the visual regression testing workflow more explicit and actionable. The update addresses an issue where the agent would create visual tests but fail to actually run them and verify the results before proceeding with migration.
Key changes:
- Restructured Step 0 with explicit sub-steps (build, generate, verify, commit) to ensure snapshots are actually created and committed before migration
- Added verification commands and checkpoints to confirm snapshots exist and are included in git commits
- Enhanced instructions to update page object imports from
base-page-objecttolit-base-page-objectduring migration - Removed redundant "What's New in V2" section while preserving all critical information in detailed workflow sections
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ```bash | ||
| # Stage all E2E files including snapshots | ||
| git add packages/atomic/src/components/**/e2e/ | ||
|
|
||
| # Commit with descriptive message | ||
| git commit -m "test: add visual regression tests and baseline snapshots for <component-name> (Stencil)" | ||
| ``` |
Copilot
AI
Nov 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent working directory assumption. In Step 0.4 (line 190), the instructions say cd packages/atomic, and Step 0.5 uses a relative path (src/components/**/e2e/__snapshots__/*.png), implying the user is still in the packages/atomic directory. However, this step uses an absolute path from the repository root (packages/atomic/src/components/**/e2e/).
Either:
- Use
src/components/**/e2e/(relative to packages/atomic) - Or add a command to return to repository root first:
cd ../..
The previous agent created the tests for the snapshots but never ran the tests