Skip to content

Conversation

@mmitiche
Copy link
Contributor

@mmitiche mmitiche commented Nov 27, 2025

KIT-5038

This PR successfully migrates the internal answer content functional components including the generated-text-content, generated-markdown-content and generated-content-container from Stencil to Lit while maintaining backward compatibility. The migration follows established patterns and preserves existing functionality for Stencil consumers.

Key changes:

  • Created new functional Lit implementation for generated-text-content, generated-markdown-content and generated-content-container.

  • Preserved Stencil version of these components stencil-*.tsx with deprecation notice for backward compatibility

  • Added comprehensive test coverage for the new Lit functional components

@mmitiche mmitiche changed the title feat(atomic): migration of generated content components to lit feat(atomic): migration of functional generated content components to lit Nov 27, 2025
@mmitiche mmitiche marked this pull request as ready for review November 27, 2025 17:53
@mmitiche mmitiche requested a review from a team as a code owner November 27, 2025 17:53
Copilot AI review requested due to automatic review settings November 27, 2025 17:53
@mmitiche mmitiche requested review from a team, lavoiesl and louis-bompart November 27, 2025 17:54
Copilot finished reviewing on behalf of mmitiche November 27, 2025 17:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR successfully migrates internal generated content functional components from Stencil to Lit, following the established migration pattern in the Atomic package. The migration creates new Lit implementations (generated-text-content.ts, generated-markdown-content.ts, generated-content-container.ts) while preserving backward compatibility by retaining deprecated Stencil versions prefixed with stencil-*. All new components include comprehensive test coverage following the established testing patterns.

Key Changes

  • New Lit functional components with proper TypeScript interfaces and render* naming convention
  • Stencil versions renamed with stencil-* prefix and marked as @deprecated
  • Comprehensive test suites using renderFunctionFixture for all new components
  • Updated import paths in consuming code to reference Stencil versions

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
stencil-generated-content-container.tsx Updated imports to reference stencil-prefixed components for backward compatibility
stencil-generated-text-content.tsx New deprecated Stencil version of text content renderer
stencil-generated-markdown-content.tsx New deprecated Stencil version of markdown content renderer
generated-text-content.ts New Lit functional component for rendering plain text generated content
generated-text-content.spec.ts Comprehensive test suite covering all text content rendering scenarios
generated-markdown-content.ts New Lit functional component for rendering markdown with DOMPurify sanitization
generated-markdown-content.spec.ts Test suite with mock validation for markdown transformation and sanitization
generated-content-container.ts New Lit functional component with children support for content container
generated-content-container.spec.ts Test suite covering format switching, streaming state, and children rendering
generated-answer-common.tsx Updated import to reference deprecated Stencil container version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@louis-bompart louis-bompart self-assigned this Nov 27, 2025
Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tweaks in the UT

@louis-bompart louis-bompart removed their assignment Nov 28, 2025
Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question, otherwise looks good!

@mmitiche mmitiche temporarily deployed to Prerelease (CDN) December 3, 2025 17:51 — with GitHub Actions Inactive
@mmitiche mmitiche added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit 561bcb6 Dec 3, 2025
82 checks passed
@mmitiche mmitiche deleted the KIT-5038 branch December 3, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants