-
Notifications
You must be signed in to change notification settings - Fork 39
docs(atomic): Migrating atomic-did-you-mean doc to storybook
#6669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
atomic-did-you-mean doc to storybookatomic-did-you-mean doc to storybook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the documentation for the atomic-did-you-mean component to Storybook by creating a new .mdx file that integrates with the existing Storybook stories.
Key Changes:
- Creates a Storybook documentation file following the
AtomicDocTemplatepattern - Adds usage examples and best practices for the component
- Includes external reference links for additional context
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ... | ||
| <atomic-layout-section section="status"> | ||
|
|
||
| <atomic-did-you-mean></atomic-commerce-did-you-mean> |
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The closing tag </atomic-commerce-did-you-mean> doesn't match the opening tag <atomic-did-you-mean>. The closing tag should be </atomic-did-you-mean> to match the opening tag.
| <atomic-did-you-mean></atomic-commerce-did-you-mean> | |
| <atomic-did-you-mean></atomic-did-you-mean> |
|
|
||
| <AtomicDocTemplate | ||
| stories={AtomicDidYouMeanStories} | ||
| githubPath="search/atomic-did-you-mean/atomic-did-you-mean.ts" |
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The githubPath points to a .ts file (atomic-did-you-mean.ts), but the actual component file is atomic-did-you-mean.tsx. This should be updated to "search/atomic-did-you-mean/atomic-did-you-mean.tsx" to point to the correct file.
| githubPath="search/atomic-did-you-mean/atomic-did-you-mean.ts" | |
| githubPath="search/atomic-did-you-mean/atomic-did-you-mean.tsx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can leave it as .ts for now as we will do the migration very soon.
|
|
||
|
|
||
| ### Common Use Cases | ||
| * The current query returns results, but the index has more frequently occurring terms with similar spelling, the component presents a link containing the new terms. |
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is incomplete and grammatically incorrect. It should read: "* When the current query returns results, but the index has more frequently occurring terms with similar spelling, the component presents a link containing the new terms."
| * The current query returns results, but the index has more frequently occurring terms with similar spelling, the component presents a link containing the new terms. | |
| * When the current query returns results, but the index has more frequently occurring terms with similar spelling, the component presents a link containing the new terms. |
| * The current query returns results, but the index has more frequently occurring terms with similar spelling, the component presents a link containing the new terms. | ||
| When clicked, the link triggers a new query using the corrected keywords. | ||
| * A soft nudge asking them if that's what they meant can direct them to the most relevant results. |
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence fragment is incomplete. It should be part of the previous bullet point or rephrased as a complete sentence. Consider: "* A soft nudge asking users if that's what they meant can direct them to the most relevant results."
| * The current query returns results, but the index has more frequently occurring terms with similar spelling, the component presents a link containing the new terms. | |
| When clicked, the link triggers a new query using the corrected keywords. | |
| * A soft nudge asking them if that's what they meant can direct them to the most relevant results. | |
| * The current query returns results, but the index has more frequently occurring terms with similar spelling. The component presents a link containing the new terms, and a soft nudge asking users if that's what they meant can direct them to the most relevant results. When clicked, the link triggers a new query using the corrected keywords. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexprudhomme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 just the copilot comment
|
|
||
| <AtomicDocTemplate | ||
| stories={AtomicDidYouMeanStories} | ||
| githubPath="search/atomic-did-you-mean/atomic-did-you-mean.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can leave it as .ts for now as we will do the migration very soon.

Jira ticket