Remove dead facet-placeholder Lit functional component files #6680
+0
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete facet-placeholder.ts and facet-placeholder.spec.ts as they are dead code - the functionality was integrated into the atomic-facet-placeholder custom element during migration. Co-authored-by: fbeaudoincoveo <23503066+fbeaudoincoveo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove dead code for facet-placeholder component
Remove dead facet-placeholder Lit functional component files
Nov 28, 2025
Copilot finished work on behalf of
fbeaudoincoveo
November 28, 2025 20:11
fbeaudoincoveo
requested review from
Copilot,
jmazzah-coveo and
louis-bompart
fbeaudoincoveo
approved these changes
Nov 28, 2025
Copilot finished reviewing on behalf of
fbeaudoincoveo
November 28, 2025 20:18
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes dead code from the Atomic package by deleting a Lit functional component implementation of facet-placeholder that was superseded by the atomic-facet-placeholder custom element during the atomic-facet migration. The functionality now lives entirely within the custom element component.
Key changes:
- Removed unused Lit functional component
renderFacetPlaceholderand its test file - Preserved
stencil-facet-placeholder.tsxwhich remains in use by legacy Stencil components
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/atomic/src/components/common/facets/facet-placeholder/facet-placeholder.ts |
Deleted dead Lit functional component that was replaced by atomic-facet-placeholder custom element |
packages/atomic/src/components/common/facets/facet-placeholder/facet-placeholder.spec.ts |
Deleted tests for the removed functional component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
louis-bompart
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
facet-placeholderfunctional component was migrated but due to miscommunication was integrated directly into theatomic-facet-placeholdercustom element during the atomic-facet migration. The standalone functional component files are now dead code.Changes:
packages/atomic/src/components/common/facets/facet-placeholder/facet-placeholder.tspackages/atomic/src/components/common/facets/facet-placeholder/facet-placeholder.spec.tsThe
stencil-facet-placeholder.tsxremains in place as it's still used by legacy Stencil components.Fixes KIT-4943
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.