feat(atomic): Add support for return types in the once util function #6684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavoiesl
force-pushed
the
seb-KIT-5270-once
branch
from
9a5c947 to
9ec0939
Compare
lavoiesl
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
lavoiesl
requested review from
alexprudhomme,
Copilot,
jmazzah-coveo and
louis-bompart
louis-bompart
approved these changes
Dec 1, 2025
Copilot finished reviewing on behalf of
lavoiesl
December 1, 2025 15:18
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the once utility function by adding TypeScript generic support for return types, improving type inference when wrapping functions. The changes enable better type safety and developer experience by allowing TypeScript to infer the return type of the wrapped function.
Key Changes
- Added generic type parameter
Rto capture and preserve the return type of wrapped functions - Changed the memoization flag from setting
fn = () => {}tofn = nullto enable garbage collection of the original function reference - Added comprehensive test coverage for different function signatures (with arguments, void functions, and typed functions)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/atomic/src/utils/utils.ts | Updated once function signature with generic return type parameter and changed memoization implementation to null out function reference for garbage collection |
| packages/atomic/src/utils/utils.spec.ts | Added four new test cases covering argument handling, memoization behavior, void functions, and type inference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lavoiesl <1216046+lavoiesl@users.noreply.github.com>
lavoiesl
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-5270