Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix statement that creates coveralls-checksums.txt #166

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

afinetooth
Copy link
Member

@afinetooth afinetooth commented Oct 2, 2024

Closes:

Actually, we closed these issues with a patch in which we downloaded, changed, and re-uploaded the coveralls-checksums.txt file to release v.0.6.15, but this fix makes sure the same issue won't occur in future releases:

⚡ Summary

Fixes the statement that creates the coveralls-checksums.txt file.

☑️ Checklist

  • Fixes the statement that creates the coveralls-checksums.txt file:

    • cd into release/ directory before creating checksums on each file (so we leave out the path prefix, release/).

    Reasoning: These files will be downloaded at the root level for users of each binary, so the checksums need to refer to the files without any paths included.

@afinetooth afinetooth changed the title Fix statement that creates coveralls-checksums.txt. Fix statement that creates coveralls-checksums.txt Oct 2, 2024
Copy link

coveralls-official bot commented Oct 2, 2024

Pull Request Test Coverage Report for Build rc-aarch64-11150570657

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 90.668%

Totals Coverage Status
Change from base Build 11147643301: -3.3%
Covered Lines: 1336
Relevant Lines: 1452

💛 - Coveralls

@afinetooth afinetooth merged commit 169c57e into master Oct 2, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant