Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cobertura #25

Closed
wants to merge 5 commits into from
Closed

Support cobertura #25

wants to merge 5 commits into from

Conversation

ly-cultureiq
Copy link

i included the new node_modules - which makes it a huge diff.
the only real commits are the first 3 - and the last commit is what changed after running npm install coveralls@3.0.8

Being that this supports both lcov and cobertura - i took the liberty of changeng the param path-to-lcov to path-to-file but added a backwards compatible falback
this also adds a coverage-format param that accepts lcov or cobertura

wjt added a commit to flathub-infra/flatpak-external-data-checker that referenced this pull request Dec 6, 2019
@wjt
ci: submit coverage information to coveralls.io
2b2bdb8 
We cannot easily use the official GitHub Action from
https://github.com/marketplace/actions/coveralls-github-action because
it expects its input to be in LCOV format, which is not what coverage.py
emits. See coverallsapp/github-action#4 for
more discussion about this.

If coverallsapp/github-action#25 were merged to
support the Cobertura XML format, then `coverage xml` could be used to
generate that format. Since it's not, it's simplest to just install the
Python client for coveralls from PyPI.
wjt added a commit to flathub-infra/flatpak-external-data-checker that referenced this pull request Dec 18, 2019
@wjt
ci: submit coverage information to coveralls.io
b6511fe 
We cannot easily use the official GitHub Action from
https://github.com/marketplace/actions/coveralls-github-action because
it expects its input to be in LCOV format, which is not what coverage.py
emits. See coverallsapp/github-action#4 for
more discussion about this.

If coverallsapp/github-action#25 were merged to
support the Cobertura XML format, then `coverage xml` could be used to
generate that format. Since it's not, it's simplest to just install the
Python client for coveralls from PyPI.
wjt added a commit to flathub-infra/flatpak-external-data-checker that referenced this pull request Dec 18, 2019
@wjt
ci: submit coverage information to coveralls.io
5c9237b 
We cannot easily use the official GitHub Action from
https://github.com/marketplace/actions/coveralls-github-action because
it expects its input to be in LCOV format, which is not what coverage.py
emits. See coverallsapp/github-action#4 for
more discussion about this.

If coverallsapp/github-action#25 were merged to
support the Cobertura XML format, then `coverage xml` could be used to
generate that format. Since it's not, it's simplest to just install the
Python client for coveralls from PyPI.
wjt added a commit to flathub-infra/flatpak-external-data-checker that referenced this pull request Dec 18, 2019
@wjt
ci: submit coverage information to coveralls.io
86d0a60 
We cannot easily use the official GitHub Action from
https://github.com/marketplace/actions/coveralls-github-action because
it expects its input to be in LCOV format, which is not what coverage.py
emits. See coverallsapp/github-action#4 for
more discussion about this.

If coverallsapp/github-action#25 were merged to
support the Cobertura XML format, then `coverage xml` could be used to
generate that format. Since it's not, it's simplest to just install the
Python client for coveralls from PyPI.
barthalion pushed a commit to flathub-infra/flatpak-external-data-checker that referenced this pull request Jan 2, 2020
@wjt @barthalion
ci: submit coverage information to coveralls.io
55fac71 
We cannot easily use the official GitHub Action from
https://github.com/marketplace/actions/coveralls-github-action because
it expects its input to be in LCOV format, which is not what coverage.py
emits. See coverallsapp/github-action#4 for
more discussion about this.

If coverallsapp/github-action#25 were merged to
support the Cobertura XML format, then `coverage xml` could be used to
generate that format. Since it's not, it's simplest to just install the
Python client for coveralls from PyPI.
@MikeEdgar MikeEdgar mentioned this pull request May 6, 2020
Closed
ghost
ghost reviewed May 9, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull all

@mrexox
Copy link
Contributor

mrexox commented Feb 27, 2023 •
edited
Loading

Hey! This is a good feature. Fortunately in further versions of this Github Action we will use coverage-reporter which now has a support for cobertura reports. You can already use it directly (see its README) or wait until we will bring the support to this action.

If you have a will to rebase this PR to the current master I will definitely merge it and release a new version.

Or you can wait for the new v2 version which will support cobertura via coverage-reporter.

@mrexox
Copy link
Contributor

mrexox commented Mar 8, 2023 •
edited
Loading

Hey! v2 tag is out now. It supports cobertura coverage format, so please try it out! We'll keep improving it and extending the list of supported coverage formats. You're welcome with any issues!

If you wish to have cobertura support in v1 please reopen this PR and rebase it on master branch 🙏

@mrexox mrexox closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ly-cultureiq @mrexox