TypeLoadException error (DependencyInjection) with latest EFCore #1390

leodip · 2022-10-12T09:48:15Z

Hi,

I noticed that if I upgrade my EF Core libraries to latest (6.0.10), I get an error with coverlet:

Data collector 'XPlat code coverage' message: [coverlet]System.TypeLoadException: Could not load type 'Microsoft.Extensions.DependencyInjection.ServiceCollection' from assembly 'Microsoft.Extensions.DependencyInjection, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'.
   at Coverlet.Collector.DataCollection.CoverletCoverageCollector.GetDefaultServiceCollection(TestPlatformEqtTrace eqtTrace, TestPlatformLogger logger, String testModule)
   at Coverlet.Collector.DataCollection.CoverletCoverageCollector.OnSessionStart(Object sender, SessionStartEventArgs sessionStartEventArgs) in /_/src/coverlet.collector/DataCollection/CoverletCoverageCollector.cs:line 132.

I'm trying to upgrade Microsoft.EntityFrameworkCore from 6.0.9 to 6.0.10. My project is latest .NET 6.

Is this happening to anyone else? Is there a fix?

The text was updated successfully, but these errors were encountered:

cheesi · 2022-10-12T14:21:08Z

Yes, we have the same issue, I can confirm that we also updated all Microsoft & EF Core packages today, however, I haven't check if it is related as our pipelines didn't break. But if @leodip has it already figured out, that EF Core is the issue, it is most likely same reason for us.

Krashlog · 2022-10-12T15:10:14Z

Actually, I think it's Microsoft.Extensions.DependencyInjection 6.0.1 that is problematic (as a dependency of both EF Core and coverlet). Downgrading to 6.0.0 solved the problem in our Azure pipelines.

KlemensGenetec · 2022-10-13T12:19:02Z

Got the same issue. When calling dotnet test with --collect:XPlat Code Coverage I get the error

Data collector 'XPlat code coverage' message: [coverlet]System.TypeLoadException: Could not load type 'Microsoft.Extensions.DependencyInjection.ServiceCollection' from assembly 'Microsoft.Extensions.DependencyInjection, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. at Coverlet.Collector.DataCollection.CoverletCoverageCollector.GetDefaultServiceCollection(TestPlatformEqtTrace eqtTrace, TestPlatformLogger logger, String testModule) at Coverlet.Collector.DataCollection.CoverletCoverageCollector.OnSessionStart(Object sender, SessionStartEventArgs sessionStartEventArgs) in /_/src/coverlet.collector/DataCollection/CoverletCoverageCollector.cs:line 132.

It must be related to DependencyInjection 6.0.0 not being present in our project anymore. Funnily enough when using CollectCoverage=true in dotnet test, which causes it to use msbuild it didnt have that issue.

daveMueller · 2022-10-17T23:39:45Z

Could somebody try to provide a simple repro for that? I just tried it myself with a simple console app referencing Microsoft.Extensions.DependencyInjection 6.0.1 but didn't face this issue.

KlemensGenetec · 2022-10-18T11:15:33Z

Also tried now but it doesn't seem to be that easy to reproduce it. I just included EntityFrameworkCore as I did in the other project and used WebApplicationFactory for testing as well but i couldn't see the issue either.
So there seems to be more to it than I thought.

candritzky · 2022-10-18T11:50:10Z

Same here and definitely related to .NET 6.0.10, but not directly to EF Core.

Seems like the ServiceCollection class was been moved from Microsoft.Extensions.DependencyInjection.dll into Microsoft.Extensions.DependencyInjection.Abstractions.dll.
But this happened a long time ago, long before .NET 6 was released.
See dotnet/runtime@ad7455c

Maybe it happens because coverlet.console still targets net5.0.
See

coverlet/src/coverlet.console/coverlet.console.csproj

Line 5 in 5637470

candritzky · 2022-10-18T12:16:45Z

Happens because of the updated Microsoft.Extensions.DependencyInjection NuGet package (now version 6.0.1). This results in a newer Microsoft.Extensions.DependencyInjection.dll being copied to the bin folder (still assembly version 6.0.0.0).

If you either delete the DLL from the bin folder before running the tests, or if you manually copy Microsoft.Extensions.DependencyInjection.Abstractions.dll (from NuGet package 6.0.0 which is still latest) to the bin folder, then code coverage is working again.

Really strange...

KlemensGenetec · 2022-10-18T12:18:57Z

Got a sample working where i got the error. Hopefully its not just on my machine. For some reason it is the combination of App insights and EF.

Then did the following command: dotnet test "--collect:XPlat Code Coverage" --configuration Release --logger trx --results-directory result

console-app-master.zip

cheesi · 2022-10-18T17:03:30Z

Hey!
I downloaded the sample from @KlemensGenetec and can confirm, I got the same error. So it seems to be a machine independent working reproduction.

❯   dotnet test "--collect:XPlat Code Coverage" --configuration Release --logger trx --results-directory result
  Determining projects to restore...
  Restored C:\Users\Christian\Downloads\console-app-master\src\TemplateApp.ConsoleApp\TemplateApp.ConsoleApp.csproj (in 495 ms).
  Restored C:\Users\Christian\Downloads\console-app-master\tests\TemplateApp.Application.Tests\TemplateApp.Application.Tests.csproj (in 1,56 sec).
  TemplateApp.ConsoleApp -> C:\Users\Christian\Downloads\console-app-master\src\TemplateApp.ConsoleApp\bin\Release\net6.0\TemplateApp.ConsoleApp.dll
  TemplateApp.Application.Tests -> C:\Users\Christian\Downloads\console-app-master\tests\TemplateApp.Application.Tests\bin\Release\net6.0\TemplateApp.Application.Tests.dll
Test run for C:\Users\Christian\Downloads\console-app-master\tests\TemplateApp.Application.Tests\bin\Release\net6.0\TemplateApp.Application.Tests.dll (.NETCoreApp,Version=v6.0)
Microsoft (R) Test Execution Command Line Tool Version 17.3.1 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Data collector 'XPlat code coverage' message: [coverlet]System.TypeLoadException: Could not load type 'Microsoft.Extensions.DependencyInjection.ServiceCollection' from assembly 'Microsoft.Extensions.DependencyInjection, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'.
   at Coverlet.Collector.DataCollection.CoverletCoverageCollector.GetDefaultServiceCollection(TestPlatformEqtTrace eqtTrace, TestPlatformLogger logger, String testModule)
   at Coverlet.Collector.DataCollection.CoverletCoverageCollector.OnSessionStart(Object sender, SessionStartEventArgs sessionStartEventArgs) in /_/src/coverlet.collector/DataCollection/CoverletCoverageCollector.cs:line 132.
test

Results File: C:\Users\Christian\Downloads\console-app-master\result\Christian_WORKSTATION_2022-10-18_19_02_04.trx

Passed!  - Failed:     0, Passed:     1, Skipped:     0, Total:     1, Duration: 207 ms - TemplateApp.Application.Tests.dll (net6.0)

Krashlog · 2022-10-18T17:22:59Z

I can repro too, using @KlemensGenetec sample.

Simply removing the AppInsight nuget package is enough for the tests to work again.

rodchenkov · 2022-10-19T10:53:22Z

I have the same issue, can someone suggest a solution for pipeline?

KlemensGenetec · 2022-10-19T11:25:14Z

You can use something similar to dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=opencover --configuration Release --logger trx --results-directory result

Then you need to make sure that <IsTest>true</IsTest> is in the test project and probably add <PackageReference Include="coverlet.msbuild" Version="3.1.2"> to the test project too.

That will work if you have msbuild installed.

rodchenkov · 2022-10-19T11:48:14Z

@KlemensGenetec thanks for suggestion, but I'm using linux builds and this command:
dotnet test --configuration Release --no-restore --collect:"XPlat Code Coverage" --settings .runsettings -- RunConfiguration.DisableAppDomain=true
Looks like we need update of coverlet package to search 'Microsoft.Extensions.DependencyInjection.ServiceCollection' in Microsoft.Extensions.DependencyInjection.Abstractions.dll to a new path.

rodchenkov · 2022-10-19T13:23:03Z

I agree with @Krashlog about "Microsoft.ApplicationInsights.AspNetCore". If I remove it from reference than all start working. Also I see Microsoft.Extensions.DependencyInjection.dll after removing "Microsoft.ApplicationInsights.AspNetCore"

rodchenkov · 2022-10-19T14:10:20Z

Shall we go to "Microsoft.ApplicationInsights.AspNetCore" and create issue there?

daveMueller · 2022-10-19T22:31:53Z

@KlemensGenetec thanks for the repro. I'm not 100% sure what exactly the problem is yet, but it is definitely related to the change @candritzky mentioned here:

Seems like the ServiceCollection class was been moved from Microsoft.Extensions.DependencyInjection.dll into Microsoft.Extensions.DependencyInjection.Abstractions.dll. But this happened a long time ago, long before .NET 6 was released. See dotnet/runtime@ad7455c

Coverlet currently references both Microsoft.Extensions.DependencyInjection and Microsoft.Extensions.DependencyInjection.Abstractions which somehow leads to incompatibilities with the ServiceCollection in the new version.

I compiled a new version of coverlet that at least solved this issue for the repro. I would be happy if someone could give it a try. 😄

coverlet.3.1.3-preview.16.zip

cheesi · 2022-10-19T23:49:41Z

Hey @daveMueller !
I tested it with one of our services and it seems to work!

Microsoft (R) Test Execution Command Line Tool Version 17.3.1 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Attachments:
  C:\Users\Christian\source\repos\Service\tests\Service.A.Tests\TestResults\e33618a8-c236-4998-937b-7d7ba0f2e6c3\coverage.cobertura.xml
Passed!  - Failed:     0, Passed:    47, Skipped:     0, Total:    47, Duration: 323 ms - Service.A.Tests.dll (net6.0)

Attachments:
  C:\Users\Christian\source\repos\Service\tests\Service.B.Tests\TestResults\8f892410-9325-47e0-8023-be81f6b051b6\coverage.cobertura.xml
Passed!  - Failed:     0, Passed:     6, Skipped:     0, Total:     6, Duration: 370 ms - Service.B.Tests.dll (net6.0)

Attachments:
  C:\Users\Christian\source\repos\Service\tests\Service.C.Tests\TestResults\af7d88ac-ec8f-4cdd-9d6f-93f50f918b12\coverage.cobertura.xml
Passed!  - Failed:     0, Passed:    41, Skipped:     0, Total:    41, Duration: 2 s - Service.C.Tests.dll (net6.0)

And I get a coverage.opencover.xml file:

MarcoK80 · 2022-10-20T08:26:58Z

How fast can this be released? We have only 1 week to get this in or we need to downgrade Microsoft NuGets again. Thx

daveMueller · 2022-10-20T22:06:24Z

@cheesi cool thanks. I'll create a PR for this and try to discuss it with the other maintainers. @MarcoK80 a release in the next week is really unlikely. But maybe we can get a solution merged which then can be consumed by referencing our nightly build version.

bhugot · 2022-10-25T14:22:18Z

Hello hope we can have the fix soon but I find it really strange that you have any dependency risk with the instrumented code and library .

petli · 2022-10-27T07:56:14Z

Merged so will get into the nightly builds now:
https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md

rodchenkov · 2022-10-27T11:16:51Z

Sorry, do you have any plans when it will be released?

petli · 2022-10-27T11:23:14Z

Ping @MarcoRossignoli

MarcoRossignoli · 2022-10-27T11:40:06Z

By the end of the week I should be able to release a minor release

MarcoK80 · 2022-10-27T11:40:41Z

By the end of the week I should be able to release a patch release

Which is very good and helps us

MarcoRossignoli · 2022-10-29T15:18:34Z

3.2.0 released

KrzysztofPajak · 2022-10-29T17:42:32Z

@MarcoRossignoli Thanks, everythings works properly

qdraw mentioned this issue Oct 12, 2022

.NET SDK Upgrade to 6.0.402 qdraw/starsky#912

Closed

hocinehacherouf mentioned this issue Oct 13, 2022

Bug: Codecov is unable to find unit tests coverage report file CGI-FR/IoT-Hub-Portal#1336

Closed

daveMueller added the needs repro Needs repro to be investigated, cannot repro in local label Oct 17, 2022

petli mentioned this issue Oct 19, 2022

Upgrade to .net core 6.0.10 and Microsoft.Extensions.DependencyInjection 6.0.1 caused to stop coverlet #1394

Closed

daveMueller added with repro Issue with repro waiting for customer Waiting for customer action and removed needs repro Needs repro to be investigated, cannot repro in local labels Oct 19, 2022

daveMueller mentioned this issue Oct 21, 2022

TypeLoadException for certain combinations with Microsoft.Extensions.DependencyInjection 6.0.1 #1395

Merged

petli closed this as completed in #1395 Oct 27, 2022

rodchenkov mentioned this issue Oct 30, 2022

Data collector did not generate coverage.cobertura.xml FortuneN/FineCodeCoverage#301

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TypeLoadException error (DependencyInjection) with latest EFCore #1390

TypeLoadException error (DependencyInjection) with latest EFCore #1390

leodip commented Oct 12, 2022

cheesi commented Oct 12, 2022

Krashlog commented Oct 12, 2022

KlemensGenetec commented Oct 13, 2022

daveMueller commented Oct 17, 2022

KlemensGenetec commented Oct 18, 2022

candritzky commented Oct 18, 2022 •

edited

Loading

candritzky commented Oct 18, 2022

KlemensGenetec commented Oct 18, 2022

cheesi commented Oct 18, 2022

Krashlog commented Oct 18, 2022

rodchenkov commented Oct 19, 2022

KlemensGenetec commented Oct 19, 2022

rodchenkov commented Oct 19, 2022

rodchenkov commented Oct 19, 2022

rodchenkov commented Oct 19, 2022

daveMueller commented Oct 19, 2022 •

edited

Loading

cheesi commented Oct 19, 2022

MarcoK80 commented Oct 20, 2022

daveMueller commented Oct 20, 2022

bhugot commented Oct 25, 2022

petli commented Oct 27, 2022

rodchenkov commented Oct 27, 2022

petli commented Oct 27, 2022

MarcoRossignoli commented Oct 27, 2022 •

edited

Loading

MarcoK80 commented Oct 27, 2022

MarcoRossignoli commented Oct 29, 2022 •

edited

Loading

KrzysztofPajak commented Oct 29, 2022

TypeLoadException error (DependencyInjection) with latest EFCore #1390

TypeLoadException error (DependencyInjection) with latest EFCore #1390

Comments

leodip commented Oct 12, 2022

cheesi commented Oct 12, 2022

Krashlog commented Oct 12, 2022

KlemensGenetec commented Oct 13, 2022

daveMueller commented Oct 17, 2022

KlemensGenetec commented Oct 18, 2022

candritzky commented Oct 18, 2022 • edited Loading

candritzky commented Oct 18, 2022

KlemensGenetec commented Oct 18, 2022

cheesi commented Oct 18, 2022

Krashlog commented Oct 18, 2022

rodchenkov commented Oct 19, 2022

KlemensGenetec commented Oct 19, 2022

rodchenkov commented Oct 19, 2022

rodchenkov commented Oct 19, 2022

rodchenkov commented Oct 19, 2022

daveMueller commented Oct 19, 2022 • edited Loading

cheesi commented Oct 19, 2022

MarcoK80 commented Oct 20, 2022

daveMueller commented Oct 20, 2022

bhugot commented Oct 25, 2022

petli commented Oct 27, 2022

rodchenkov commented Oct 27, 2022

petli commented Oct 27, 2022

MarcoRossignoli commented Oct 27, 2022 • edited Loading

MarcoK80 commented Oct 27, 2022

MarcoRossignoli commented Oct 29, 2022 • edited Loading

KrzysztofPajak commented Oct 29, 2022

candritzky commented Oct 18, 2022 •

edited

Loading

daveMueller commented Oct 19, 2022 •

edited

Loading

MarcoRossignoli commented Oct 27, 2022 •

edited

Loading

MarcoRossignoli commented Oct 29, 2022 •

edited

Loading