Adjust Unit test commands due to recent dotnet changes #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree company="Geotab" |
added 12 commits
August 16, 2024 15:45
…nit testing with existing tests
…asic code clean up
JosephSun2003
changed the title
JosephSun2003
changed the title
* Revert "Revert changes to CoverageWrapper.cs and ICoverageWrapper.cs" This reverts commit 25feb24. * Revert "Adjust arguement name to trigger the skip of coverage calculation" This reverts commit c54c5cf. * Revert "Add unit tests to new methods" This reverts commit c3905a1. * Revert "Revert refactorings caught by Geotab Analyzers" This reverts commit cbe14cc. * Revert "add unload modules unique specifically for use in coverlet.console" This reverts commit 98f1f75. * Revert "Remove possibly unneeded variables" This reverts commit 6d2dd57. * Revert "Unrollback change removals to integrate new changes with VSTest Integration" This reverts commit 9d4de10. * Revert "Refactor explicit and implicit variable usage to comply with dotnet code style rules" This reverts commit e67ba69. * Revert "Add minor documentation corrections and remove unneeded changes" This reverts commit da1257e. * Revert "Update documentation to clarify the modifications made and add some basic code clean up" This reverts commit 0dfef6f. * Revert "Fix problems encountered with newly added method and variables from unit testing with existing tests" This reverts commit dcc3c29. * Revert "Add new method to manually call the unloading of modules" This reverts commit 88a5782. --------- Co-authored-by: Joseph Sun <josephsun@geotab.com>
MarcoRossignoli
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Coverlet Team,
While I was working on the fork of coverlet and I've noticed some weird behaviour when trying to execute the unit tests following the instructions listed in Contributions.md.
Due to the changes noted here: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/dotnet-pack-config the commands for dotnet pack need to specify a
-c Debugparameter in order to place the artifacts in the /Debug folder.