Fix RuntimeConfigurationReader to support SelfContained builds #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SelfContained builds to not contain the `frameworks` node in the `runtimeconfig.json` file. They do however contain a `includedFrameworks` node. Details can be found here: dotnet/sdk#3541 Running tests against a built assembly with the `SelfContained` option does result in the following often discussed error message > Unable to instrument module
|
@dotnet-policy-service agree company="Cyan IT GmbH" |
|
Anything I can do, to push this forward? :-) |
MarcoRossignoli
approved these changes
Nov 18, 2024
Bertk
pushed a commit
to Bertk/coverlet
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelfContained builds to not contain the
frameworksnode in theruntimeconfig.jsonfile. They do however contain aincludedFrameworksnode. Details can be found here: dotnet/sdk#3541Running tests against a built assembly with the
SelfContainedoption does result in the following often discussed error message