-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign collector and update visibility #566
Sign collector and update visibility #566
Conversation
coverlet.collector.snk public key
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reservations about exposing coverlet.core
publicly
@tonerdo I don't have a strong opinion about it...I don't know if this scenario makes sense. The idea of this PR is sign and "clean", I labeled with no merge because we need to have some feedback by vstest team, I've asked here https://github.com/microsoft/vstest/pull/2020/files#r327122741 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@vagisha-nidhi merged FYI |
contributes to #555
I've signed collector and updated all visibility of object.
This is a first step to expose coverage.core.dll as a lib, we'll expose only public pertinent object through interfaces/factories to be free to update internal implementation.
AFTER MERGE WE MUST UPDATE VSTEST RUNTIME AND DO SOME TESTS https://github.com/microsoft/vstest/pull/2020/files
cc: @tonerdo @vagisha-nidhi @petli