Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign collector and update visibility #566

Merged

Conversation

MarcoRossignoli
Copy link
Collaborator

contributes to #555

I've signed collector and updated all visibility of object.
This is a first step to expose coverage.core.dll as a lib, we'll expose only public pertinent object through interfaces/factories to be free to update internal implementation.

AFTER MERGE WE MUST UPDATE VSTEST RUNTIME AND DO SOME TESTS https://github.com/microsoft/vstest/pull/2020/files

cc: @tonerdo @vagisha-nidhi @petli

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented Sep 23, 2019

coverlet.collector.snk public key

C:\git\coverlet\src\coverlet.collector (signcollector -> origin)
λ sn -tp token.snk

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Public key (hash algorithm: sha1):
00240000048000009400000006020000002400005253413100040000010001003d23b9ef372215
da7c81af920b919db5799fd021a1ca10b2e9e0ddac71237a29f8f6361a805a747457e561a7d616
417f1870cda099486df25d580a4e11a0738293342881566254d7840e42f42fb9bfd8e8dca354df
7dc68db14b2d0cd79bb2bf7afdbd62bd948d81b534cba7a326cf6ee840a1aee5dba0a1c660b308
13ca99e5

Public key token is 4beb1ad7f05a1c71

C:\git\coverlet\src\coverlet.collector (signcollector -> origin)
λ sn -t token.snk

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Public key token is 4beb1ad7f05a1c71

@MarcoRossignoli MarcoRossignoli added the enhancement General enhancement request label Sep 23, 2019
@MarcoRossignoli MarcoRossignoli added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 23, 2019
Copy link
Collaborator

@tonerdo tonerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reservations about exposing coverlet.core publicly

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented Sep 27, 2019

I have reservations about exposing coverlet.core publicly

@tonerdo I don't have a strong opinion about it...I don't know if this scenario makes sense.
If you remember we talked about it some time ago #212 and also in there I wasn't so "happy" about.
We can decide to wait for more community pressure.
BTW do you agree in hiding all implementation to be more clean?
I like the idea that if someone add reference directly to coverlet libs doesn't see anything.
@petli thought?

The idea of this PR is sign and "clean", I labeled with no merge because we need to have some feedback by vstest team, I've asked here https://github.com/microsoft/vstest/pull/2020/files#r327122741
cc: @vagisha-nidhi @cltshivash

@MarcoRossignoli MarcoRossignoli removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 29, 2019
@MarcoRossignoli
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MarcoRossignoli MarcoRossignoli merged commit 63dbda8 into coverlet-coverage:master Nov 29, 2019
@MarcoRossignoli MarcoRossignoli deleted the signcollector branch November 29, 2019 20:41
@MarcoRossignoli
Copy link
Collaborator Author

@vagisha-nidhi merged FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants