Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several changes version v0.1.1 #9

Merged
merged 4 commits into from
Aug 14, 2020
Merged

Conversation

dgonzalez
Copy link
Contributor

  • Added: Added ability to set ECS image url and image tag overrides, this is based on @segfault's PR at Feature Lambda buckets & ECS tags #4
  • Updated: Switched lambdas from using the AWSLambdaBasicExecutionRole to AWSLambdaVPCAccessExecutionRole managed policy
  • Updated: Renamed the "root_profile" var and "root" AWS provider to "dns" as this is confusing, removed a redundant aws provider "root_us"
  • Updated: Added changes @segfault added re explicit usage of the AWS CLI --output json usage in some of the scripts
  • Removed: Removed Terraform validate from the pre-commit hook config as this is being used as a module, have left the s3 backend config for now
  • Updated: Switched all the lambdas from nodejs10.x to nodejs12.x
  • Added: Use variables for the lambda memory size and timeout attributes with defaults, so we can configure via env-vars files
  • Removed: Extracted cti, gct and ni content into specific repos - Will not be managed by this repo
  • Added: Added new AWS parameters certificate_audience and jwt_issuer and removed security_exposure_limit AWS parameter
  • Added: Docs on the 2 approaches to managing a project - external to this repo and internal to this repo
  • Added: Added RDS reader/writer endpoint outputs
  • Added: Surfaced bastion ASG desired count as a variable, will need when we use this repo as a module
  • Added: Switched to using path.module prefixes for the CloudWatch dashboard template and the ECS container defintion templates
  • Fixed: Changed the create TF store backend script to cater for us-east-1 being a special case - Location constraints
  • Fixed: Replace all refs to cti, gct and ni with xyz in docs and shell script comments - this is just prep for the open source branch
  • Added: Added the following optional lambdas to the operators group execute list: daily-registrations-reporter, download and upload
  • Added: Pre-commit hook to include TF fmt, validation and linting
  • Fixed: Linting issues - no logic
  • Added: Split RDS user usage so we no longer need to use the master credentials

From now on, we will have more atomic PRs.

dgonzalez and others added 2 commits August 13, 2020 11:49
* sync into covidgreen
* Synced with latest master branch from archived repo (#2)
* Updated the changelog with v0.1.1 info

Co-authored-by: root <root@DESKTOP-GE435NL.localdomain>
Co-authored-by: pmcgrath <pmcgrath@gmail.com>
@dgonzalez dgonzalez requested review from jasnell, segfault and colmharte and removed request for jasnell and segfault August 13, 2020 13:37
Copy link
Contributor

@segfault segfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@jasnell
Copy link
Contributor

jasnell commented Aug 13, 2020

Woo! Thank you for the detail pull request summary @dgonzalez :-)

Update the AWS provider from "= 2.68.0" to "~> 2.70.0" this is a requirement for the module we will use for ALB logging
Replace deprecated template provider usage with templatefile function usage
Cannot remove this till we have applied on all envs as we need to update the TF state
Copy link
Contributor

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp lgtm

@dgonzalez dgonzalez merged commit b6ba5c5 into covidgreen:current Aug 14, 2020
segfault referenced this pull request in covid-alert-ny/covid-green-infra Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants