Converts verse numbers to superscript #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great @adhason ! |
|
Thanks for this – I wonder why the 1, 2, 3 are rendering strangely for some fonts (Helvetica Neue, Avenir). I'm seeing that as well.
I'd like to investigate this a little more. |
bentsai
requested changes
Apr 23, 2022
|
Okay, just got that done. |
|
@adhason if you have thoughts on unit/integration testing that'd be welcome 😄 |
|
Well, one of those files was used for the double space bug. And the other ones were to learn about the workings of Beautiful Soup. I would imagine that an integration test suite is just a set of ground truth results that we would compare future fixes to? Does that sound right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows verse numbers to be displayed as superscript.
Oddly, on my MacBook, '1', '2', and '3' are a little bit lower than the rest of the numbers after converting to superscript. I don't know if this is an issue that occurs on other machines as well, but I figured that this was at least a start in the right direction.
#16 This was the feature request, for reference