fix DROP CONSTRAINT

covrom · Sep 3, 2021 · b474d17 · b474d17
1 parent 9dde696
commit b474d17
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/cmd/goerd/main.go b/cmd/goerd/main.go
@@ -67,7 +67,8 @@ func main() {
 						fmt.Println("--", q)
 						continue
 					}
-					if strings.Contains(strings.ToUpper(q), "DROP COLUMN") {
+					if strings.Contains(strings.ToUpper(q), "DROP COLUMN") ||
+						strings.Contains(strings.ToUpper(q), "DROP CONSTRAINT") {
 						fmt.Println("--", q)
 						continue
 					}
@@ -129,7 +130,8 @@ func main() {
 						fmt.Println("--", q)
 						continue
 					}
-					if strings.Contains(strings.ToUpper(q), "DROP COLUMN") {
+					if strings.Contains(strings.ToUpper(q), "DROP COLUMN") ||
+						strings.Contains(strings.ToUpper(q), "DROP CONSTRAINT") {
 						fmt.Println("--", q)
 						continue
 					}
@@ -151,7 +153,8 @@ func main() {
 						fmt.Println("--", q)
 						continue
 					}
-					if strings.Contains(strings.ToUpper(q), "DROP COLUMN") {
+					if strings.Contains(strings.ToUpper(q), "DROP COLUMN") ||
+						strings.Contains(strings.ToUpper(q), "DROP CONSTRAINT") {
 						fmt.Println("--", q)
 						continue
 					}
@@ -224,7 +227,8 @@ func main() {
 						fmt.Println("--", q)
 						continue
 					}
-					if strings.Contains(strings.ToUpper(q), "DROP COLUMN") {
+					if strings.Contains(strings.ToUpper(q), "DROP COLUMN") ||
+						strings.Contains(strings.ToUpper(q), "DROP CONSTRAINT") {
 						fmt.Println("--", q)
 						continue
 					}
@@ -246,7 +250,8 @@ func main() {
 						fmt.Println("--", q)
 						continue
 					}
-					if strings.Contains(strings.ToUpper(q), "DROP COLUMN") {
+					if strings.Contains(strings.ToUpper(q), "DROP COLUMN") ||
+						strings.Contains(strings.ToUpper(q), "DROP CONSTRAINT") {
 						fmt.Println("--", q)
 						continue
 					}

diff --git a/schema/diff.go b/schema/diff.go
@@ -315,7 +315,10 @@ func (c *PatchConstraint) alter() []string {
 }
 
 func (c *PatchConstraint) drop() []string {
-	// always drop unused constraints
+	if c.to == nil && c.from.Type == TypePK {
+		// pk not drop
+		return nil
+	}
 	return []string{
 		fmt.Sprintf("ALTER TABLE %s DROP CONSTRAINT IF EXISTS %s", c.tableName, c.from.Name),
 	}