Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Opera sniff #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove Opera sniff #4

wants to merge 1 commit into from

Conversation

miketaylr
Copy link

SUP BEN.

Opera 9.64 is like, 9 versions old. I know Ryan has a fork that normalizes its old document.postMessage implementation--but I think that's going to help like 0.01% of all Opera users. So....this is easier and won't break any sites or provide a crappy fallback for current Opera users.

@miketaylr
Copy link
Author

Ben, want me to um write a test for this or something?

@miketaylr
Copy link
Author

Beatport.com users can't complete the checkout process because of this sniff now too. 😞

@alexmchardy
Copy link

We're patched now at Beatport. Thanks for the fix!

@jtsoi
Copy link

jtsoi commented Mar 21, 2012

I was about to make the same pull request, Opera now supports postMesage.

Ben, are you alive? =)

/JT

@chrisdavidmills
Copy link

+1 on this from me too!

@alloy-d
Copy link

alloy-d commented May 10, 2012

Yet another +1.

@tagawa
Copy link

tagawa commented May 11, 2012

Another +1 here.

@andreasbovens
Copy link

And another +1 from me.

@freddywang
Copy link

for Opera, use

window.addEventListener('message', callback, false)

instead of

window.addEventListener('message', callback, !1)

I checked on opera 12, it doesn't work when we pass !1 as third argument of addEventListener method

@abhishekdev
Copy link

If not removed this "sniffing" statement should be modified for compatibility with jQuery 1.9.x+ as $.browser is deprecated now.

@Calvein
Copy link

Calvein commented Apr 15, 2013

👍

1 similar comment
@lukeasrodgers
Copy link

👍

@damienwhaley
Copy link

Further to this I have modified the browser sniff so that it does not fail on jQuery 1.9.x+ and I have added a note to the README to use the jQuery.browser plugin.

ben-duo added a commit to duosecurity/duo_ruby that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_splunk that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_perl that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_confluence that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_wordpress that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_dotnet that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_java that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_coldfusion that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_php that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_nodejs that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_python that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_mediawiki that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_drupal that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_mediawiki that referenced this pull request Jan 3, 2014
ben-duo added a commit to duosecurity/duo_classicasp that referenced this pull request Jan 3, 2014
@miketaylr
Copy link
Author

hi ben, miss u. ❤️

@vladikoff
Copy link

Yesss!

@buritica
Copy link

🎂 happy bday PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.