SAI-4358 : PRS collection deletion race condition #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added unit test case in ZkStateReaderTest#testDeletePrsCollection
hiteshk25
reviewed
May 24, 2023
| @@ -35,6 +36,8 @@ public class PerReplicaStatesFetcher { | |||
| public static PerReplicaStates fetch( | |||
| String path, SolrZkClient zkClient, PerReplicaStates current) { | |||
| try { | |||
| assert CommonTestInjection.injectBreakpoint( | |||
There was a problem hiding this comment.
Why we need to assert here?
There was a problem hiding this comment.
so that for normal execution (non unit test), this call will be ignored
…undException as their conditions/handling are quite different.
patsonluk
added a commit
that referenced
this pull request
May 24, 2023
* Adding Breakpoint injection to CommonTestInjection * ./gradlew tidy * Fixed javadoc * Fixed race condition for PRS collection on deletion Added unit test case in ZkStateReaderTest#testDeletePrsCollection * ./gradlew tidy * Separate the exception handling of NoNodeException and PrsZkNodeNotFoundException as their conditions/handling are quite different. * Fixed Execution failed for task ':solr:solrj-zookeeper:validateLogCalls'. * ./gradlew tidy * Fixed validateLogCalls
patsonluk
added a commit
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is just a cherry pick of commits from apache#1460
Detailed described in the above link
We are creating this PR as we want such change in our own repo (ran into that occasionally on playpen eu1 c91) as the upstream change is still under review
This same was reviewed for 8.8 as in fullstorydev/lucene-solr#210