chore: migrate E2E wineOilMarket tests to Foundry #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedgiac
reviewed
Sep 10, 2024
meetmangukiya
force-pushed
the
e2e-migrate-wineOilMarket
branch
from
0921f74
to
66991a0
Compare
mfw78
approved these changes
Sep 24, 2024
| tokens[1] = oil; | ||
| tokens[2] = wine; | ||
| uint256[] memory prices = new uint256[](3); | ||
| prices[0] = 1 ether; |
There was a problem hiding this comment.
nit: for readability, maybe allocate to a variable per oilPrice and winePrice unless there's stack too deep issues.
There was a problem hiding this comment.
i dont understand what you mean
There was a problem hiding this comment.
It is odd to have oilPrice and winePrice and not have eurPrice. So, at LN108 I'd suggest adding a eurPrice variable.
mfw78
approved these changes
Sep 24, 2024
mfw78
force-pushed
the
e2e-migrate-wineOilMarket
branch
from
3f45967
to
9fed3fc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate wineOilMarket e2e test to foundry. Depends on #215 for the
ForkedTest.t.sol.Test Plan
CI
Related Issues
Closes #143