Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sepolia network #189

Merged
merged 1 commit into from
Dec 26, 2023
Merged

feat: sepolia network #189

merged 1 commit into from
Dec 26, 2023

Conversation

shoom3301
Copy link
Contributor

No description provided.

@shoom3301 shoom3301 requested a review from a team December 26, 2023 10:16
@shoom3301 shoom3301 self-assigned this Dec 26, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

shoom3301
shoom3301 commented Dec 26, 2023
View reviewed changes
src/common/consts.ts

export const BUY_ETH_ADDRESS = '0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE'
export const EXTENSIBLE_FALLBACK_HANDLER = '0x2f55e8b20D0B9FEFA187AA7d00B6Cbe563605bF5'
export const COMPOSABLE_COW = '0xfdaFc9d1902f4e0b84f65F49f244b32b31013b74'
const SETTLEMENT_CONTRACT = '0x9008D19f58AAbD9eD0D60971565AA8510560ab41'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/cowprotocol/contracts/blob/main/networks.json

@shoom3301
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Dec 26, 2023
@github-actions
@shoom3301 has signed the CLA from Pull Request #189
3a6be2a
@shoom3301 shoom3301 force-pushed the feat/sepolia branch 3 times, most recently from dd73444 to 042ffb2 Compare December 26, 2023 10:25
@coveralls
Copy link
Collaborator

coveralls commented Dec 26, 2023 •
edited
Loading

Coverage Status

coverage: 79.075% (+0.02%) from 79.051%
when pulling a6a44fd on feat/sepolia
into 1dfac8d on main.

shoom3301
shoom3301 commented Dec 26, 2023
View reviewed changes
src/subgraph/api.ts Outdated Show resolved Hide resolved
alfetopito
alfetopito reviewed Dec 26, 2023
View reviewed changes
src/common/consts.ts Show resolved Hide resolved
src/order-book/generated/models/OrderPostError.ts Outdated Show resolved Hide resolved
src/subgraph/api.ts Outdated Show resolved Hide resolved
@shoom3301 shoom3301 force-pushed the feat/sepolia branch 2 times, most recently from 72f0fe1 to 63a75eb Compare December 26, 2023 10:49
@alfetopito alfetopito mentioned this pull request Dec 26, 2023
Open
@alfetopito
Copy link
Contributor

Oh, there's one lint issue
image

@shoom3301 shoom3301 force-pushed the feat/sepolia branch 2 times, most recently from b936ce0 to f5d482e Compare December 26, 2023 11:23
@shoom3301 shoom3301 merged commit d0d86a9 into main Dec 26, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
@alfetopito alfetopito deleted the feat/sepolia branch December 26, 2023 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

Assignees

@shoom3301 shoom3301

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoom3301 @coveralls @alfetopito