fix(usdt-approval): 🐛 fix wallet connect with safe causing same nonce to appear twice #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
reviewed
May 24, 2023
anxolin
approved these changes
May 25, 2023
|
|
||
| // For Wallet Connect based Safe Wallet connections, wait for transaction to be executed. | ||
| if (txReceipt && safeApiKit && isSafeWallet && isWalletConnect) { | ||
| await waitForSafeTransactionExecution({ safeApiKit, txHash: txReceipt.hash }) |
alfetopito
reviewed
May 25, 2023
Comment on lines
+43
to
+44
| const isWalletConnect = useIsActiveWallet(walletConnectConnection) | ||
| const isSafeWallet = useIsSafeWallet() |
There was a problem hiding this comment.
Oh, I have a hook for that
There was a problem hiding this comment.
Oh nice - will iterate on it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2532
Safe has an issue with wallet connect where when we send two transactions back to back, they repeat the nonce, causing transaction to fail.
This change introduces a fix by;
To Test
Background
safe-global/safe-wallet-monorepo#2034
https://cowservices.slack.com/archives/C03DVQREAH0/p1684929286045829