Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance kpi competitors #123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PoloX2021
Copy link
Contributor

Improving the speed of some queries and reverting to the prices.usd table for accurate information.
This means we won't be supporting new tokens, but it's better than having false data for all tokens.

@PoloX2021 PoloX2021 requested a review from harisang January 24, 2025 12:56
Copy link

@PoloX2021
Copy link
Contributor Author

Yes, I am sure. Prices.minute is not working at the moment.

@fhenneke
Copy link
Contributor

Prices.minute is not working at the moment.

What do you mean by that? Are values wrong? Is it too slow?

@PoloX2021
Copy link
Contributor Author

Prices.minute is not working at the moment.

What do you mean by that? Are values wrong? Is it too slow?

Both ;(
Although Dune advertises these tables on their website. The values are wrong, missing, there are duplicates. Apparently they are still working on them, but no date announced.

Copy link
Contributor

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants