-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mainnet service fee tracker query (id 4017925) #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this folder structure is not furture proof. I think this should go under cowprotocol (cf. @fhenneke's PR) -> accounting -> rewards -> mainnet
FROM ( | ||
VALUES {{BondingPoolData}} | ||
) AS _ (name, pool,funder) | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can fix the linting errors and also set the bonding pools as constants if we hardcode them like this:
WITH
bonding_pools (pool, name, initial_funder) AS (
SELECT
from_hex('0x8353713b6D2F728Ed763a04B886B16aAD2b16eBD') AS pool,
'Gnosis' AS name,
from_hex('0x6c642cafcbd9d8383250bb25f67ae409147f78b2') AS initial_funder
UNION ALL
SELECT
from_hex('0x5d4020b9261F01B6f8a45db929704b0Ad6F5e9E6') AS pool,
'CoW Services' AS name,
from_hex('0x423cec87f19f0778f549846e0801ee267a917935') AS initial_funder
),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, followed this suggestion and also renamed name
to pool_name
as i was getting some complaint.
I don't want to do any further edits though as the purpose of this PR was to push the query as is and then do another PR to actually clean it up
I have also edited the query on Dune so that it is identical to the latest commit in this PR (as again, the purpose of this PR was not to update the query but rather start tracking it). And the query seems to be working as before. |
Note that this should not be needed, merging the PR will automatically override what is stored in Dune |
This PR simply adds this query for tracking purposes
https://dune.com/queries/4017925