Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

[2.20]Orders fills: share invertPrice state between the header and body #435

Closed
elena-zh opened this issue Apr 10, 2023 · 0 comments · Fixed by #454
Closed

[2.20]Orders fills: share invertPrice state between the header and body #435

elena-zh opened this issue Apr 10, 2023 · 0 comments · Fixed by #454
Assignees
@alfetopito
Labels
app:Explorer Explorer App Bug Something isn't working limit-order Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

elena-zh commented Apr 10, 2023 •
edited
Loading

  1. Reported in Style fixes for Order fills page #423 (review)
    In this line, I would suggest a follow up, where the the invertPrice state is shared between the header and body of the table of fills

See video:

Screen.Recording.2023-04-06.at.11.37.00.mov

  1. It would be great to remove the horizontal scrollbar in a mobile view for the Fills tab fixed in Partial fills table styling #443

  2. Tablet view: it would be great to keep /Invert price' icon closer to the column name, and now it seems like it is connected to the Execution time column Fixed in Partial fills table styling #443
@elena-zh elena-zh added app:Explorer Explorer App Bug Something isn't working limit-order Low Severity indicator for defects. It won't cause any major break-down of the system labels Apr 10, 2023
This was referenced Apr 10, 2023
Merged
Merged
@elena-zh elena-zh changed the title Issues related to the Orders fills tab Orders fills: share invertPrice state between the header and body Apr 12, 2023
@elena-zh elena-zh changed the title Orders fills: share invertPrice state between the header and body [2.20]Orders fills: share invertPrice state between the header and body Apr 14, 2023
@elena-zh elena-zh mentioned this issue Apr 14, 2023
Merged
@alfetopito alfetopito self-assigned this Apr 19, 2023
@alfetopito alfetopito mentioned this issue Apr 19, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alfetopito alfetopito

Labels
app:Explorer Explorer App Bug Something isn't working limit-order Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

435/share invert price fills tab cowprotocol/explorer
2 participants
@alfetopito @elena-zh