Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

2.20.0 Relese - partial fills #446

Merged
merged 31 commits into from
Apr 14, 2023
Merged

2.20.0 Relese - partial fills #446

merged 31 commits into from
Apr 14, 2023

Conversation

alfetopito
Copy link
Collaborator

Summary

Partial fills!

dependabot bot and others added 30 commits March 22, 2023 09:00
@dependabot
Bump prettier from 2.8.2 to 2.8.4 (#385)
55e5042 
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.2 to 2.8.4.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.2...2.8.4)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump react-inlinesvg from 3.0.1 to 3.0.2 (#387)
d4b741f 
Bumps [react-inlinesvg](https://github.com/gilbarbara/react-inlinesvg) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/gilbarbara/react-inlinesvg/releases)
- [Commits](gilbarbara/react-inlinesvg@v3.0.1...v3.0.2)

---
updated-dependencies:
- dependency-name: react-inlinesvg
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @babel/register from 7.18.9 to 7.21.0 (#389)
121f408 
Bumps [@babel/register](https://github.com/babel/babel/tree/HEAD/packages/babel-register) from 7.18.9 to 7.21.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.21.0/packages/babel-register)

---
updated-dependencies:
- dependency-name: "@babel/register"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump react-hot-loader from 4.13.0 to 4.13.1 (#390)
2bc8da4 
Bumps [react-hot-loader](https://github.com/gaearon/react-hot-loader) from 4.13.0 to 4.13.1.
- [Release notes](https://github.com/gaearon/react-hot-loader/releases)
- [Changelog](https://github.com/gaearon/react-hot-loader/blob/master/CHANGELOG.md)
- [Commits](gaearon/react-hot-loader@v4.13.0...v4.13.1)

---
updated-dependencies:
- dependency-name: react-hot-loader
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @babel/core from 7.20.12 to 7.21.3 (#393)
b85b033 
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.20.12 to 7.21.3.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.21.3/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @babel/plugin-transform-runtime from 7.19.6 to 7.21.0 (#384)
a3bf3c4 
Bumps [@babel/plugin-transform-runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-runtime) from 7.19.6 to 7.21.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.21.0/packages/babel-plugin-transform-runtime)

---
updated-dependencies:
- dependency-name: "@babel/plugin-transform-runtime"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump console-feed from 3.4.3 to 3.4.5 (#394)
5b7e1c8 
Bumps [console-feed](https://github.com/samdenty/console-feed) from 3.4.3 to 3.4.5.
- [Release notes](https://github.com/samdenty/console-feed/releases)
- [Commits](https://github.com/samdenty/console-feed/commits/v3.4.5)

---
updated-dependencies:
- dependency-name: console-feed
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@nenadV91
Merge branch 'main' into develop
8507a38
@dependabot
Bump babel-loader from 8.2.3 to 8.3.0 (#403)
ced23ea 
Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.2.3 to 8.3.0.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v8.2.3...v8.3.0)

---
updated-dependencies:
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @popperjs/core from 2.11.6 to 2.11.7 (#404)
acb4fe3 
Bumps [@popperjs/core](https://github.com/popperjs/popper-core) from 2.11.6 to 2.11.7.
- [Release notes](https://github.com/popperjs/popper-core/releases)
- [Commits](floating-ui/floating-ui@v2.11.6...v2.11.7)

---
updated-dependencies:
- dependency-name: "@popperjs/core"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump styled-components from 5.3.6 to 5.3.9 (#406)
a56491e 
Bumps [styled-components](https://github.com/styled-components/styled-components) from 5.3.6 to 5.3.9.
- [Release notes](https://github.com/styled-components/styled-components/releases)
- [Commits](styled-components/styled-components@v5.3.6...v5.3.9)

---
updated-dependencies:
- dependency-name: styled-components
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump tslib from 2.3.1 to 2.5.0 (#405)
1696ec2 
Bumps [tslib](https://github.com/Microsoft/tslib) from 2.3.1 to 2.5.0.
- [Release notes](https://github.com/Microsoft/tslib/releases)
- [Commits](microsoft/tslib@2.3.1...2.5.0)

---
updated-dependencies:
- dependency-name: tslib
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @apollo/client from 3.7.9 to 3.7.10 (#407)
08a58f1 
Bumps [@apollo/client](https://github.com/apollographql/apollo-client) from 3.7.9 to 3.7.10.
- [Release notes](https://github.com/apollographql/apollo-client/releases)
- [Changelog](https://github.com/apollographql/apollo-client/blob/main/CHANGELOG.md)
- [Commits](apollographql/apollo-client@v3.7.9...v3.7.10)

---
updated-dependencies:
- dependency-name: "@apollo/client"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @fortawesome/free-solid-svg-icons from 6.1.2 to 6.3.0 (#402)
37bac42 
Bumps [@fortawesome/free-solid-svg-icons](https://github.com/FortAwesome/Font-Awesome) from 6.1.2 to 6.3.0.
- [Release notes](https://github.com/FortAwesome/Font-Awesome/releases)
- [Changelog](https://github.com/FortAwesome/Font-Awesome/blob/6.x/CHANGELOG.md)
- [Commits](FortAwesome/Font-Awesome@6.1.2...6.3.0)

---
updated-dependencies:
- dependency-name: "@fortawesome/free-solid-svg-icons"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@anxolin
Merge branch 'main' into develop
eff8562
@alfetopito
Partial fills surplus (#414)
a42d3f2 
* Added partial fills support to surplus calculation

* Added unittests for new partial fills surplus calculation

* Fixing comment

* Removed commented dead code
@dependabot
Bump playwright from 1.31.1 to 1.32.1 (#415)
ae98ab3 
Bumps [playwright](https://github.com/Microsoft/playwright) from 1.31.1 to 1.32.1.
- [Release notes](https://github.com/Microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.31.1...v1.32.1)

---
updated-dependencies:
- dependency-name: playwright
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @babel/preset-env from 7.20.2 to 7.21.4 (#417)
ee90f56 
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.20.2 to 7.21.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.21.4/packages/babel-preset-env)

---
updated-dependencies:
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @fortawesome/fontawesome-common-types from 6.3.0 to 6.4.0 (#419)
f3fe386 
Bumps [@fortawesome/fontawesome-common-types](https://github.com/FortAwesome/Font-Awesome) from 6.3.0 to 6.4.0.
- [Release notes](https://github.com/FortAwesome/Font-Awesome/releases)
- [Changelog](https://github.com/FortAwesome/Font-Awesome/blob/6.x/CHANGELOG.md)
- [Commits](FortAwesome/Font-Awesome@6.3.0...6.4.0)

---
updated-dependencies:
- dependency-name: "@fortawesome/fontawesome-common-types"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @babel/core from 7.21.3 to 7.21.4 (#420)
9b81b48 
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.21.3 to 7.21.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.21.4/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@shoom3301
Update cow-sdk to v2 (#422)
1dc48b1 
* Update cow-sdk to v2

* Fix subgraphApiSDK
@dependabot
Bump prettier from 2.8.4 to 2.8.7 (#428)
10db705 
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.4 to 2.8.7.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.4...2.8.7)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @types/react from 16.14.35 to 16.14.38 (#427)
483fc0d 
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 16.14.35 to 16.14.38.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump playwright from 1.32.1 to 1.32.2 (#429)
1fc0a08 
Bumps [playwright](https://github.com/Microsoft/playwright) from 1.32.1 to 1.32.2.
- [Release notes](https://github.com/Microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.32.1...v1.32.2)

---
updated-dependencies:
- dependency-name: playwright
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump console-feed from 3.4.5 to 3.5.0 (#431)
8a54e51 
Bumps [console-feed](https://github.com/samdenty/console-feed) from 3.4.5 to 3.5.0.
- [Release notes](https://github.com/samdenty/console-feed/releases)
- [Commits](samdenty/console-feed@v3.4.5...v3.5.0)

---
updated-dependencies:
- dependency-name: console-feed
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @apollo/client from 3.7.10 to 3.7.11 (#432)
32d44de 
Bumps [@apollo/client](https://github.com/apollographql/apollo-client) from 3.7.10 to 3.7.11.
- [Release notes](https://github.com/apollographql/apollo-client/releases)
- [Changelog](https://github.com/apollographql/apollo-client/blob/main/CHANGELOG.md)
- [Commits](apollographql/apollo-client@v3.7.10...v3.7.11)

---
updated-dependencies:
- dependency-name: "@apollo/client"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @cowprotocol/cow-sdk from 2.0.0 to 2.0.1 (#430)
8a9c2ab 
Bumps @cowprotocol/cow-sdk from 2.0.0 to 2.0.1.

---
updated-dependencies:
- dependency-name: "@cowprotocol/cow-sdk"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @fortawesome/fontawesome-svg-core from 6.3.0 to 6.4.0 (#433)
16fd0e7 
Bumps [@fortawesome/fontawesome-svg-core](https://github.com/FortAwesome/Font-Awesome) from 6.3.0 to 6.4.0.
- [Release notes](https://github.com/FortAwesome/Font-Awesome/releases)
- [Changelog](https://github.com/FortAwesome/Font-Awesome/blob/6.x/CHANGELOG.md)
- [Commits](FortAwesome/Font-Awesome@6.3.0...6.4.0)

---
updated-dependencies:
- dependency-name: "@fortawesome/fontawesome-svg-core"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @babel/plugin-transform-runtime from 7.21.0 to 7.21.4 (#434)
8d1e4a9 
Bumps [@babel/plugin-transform-runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-runtime) from 7.21.0 to 7.21.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.21.4/packages/babel-plugin-transform-runtime)

---
updated-dependencies:
- dependency-name: "@babel/plugin-transform-runtime"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@anxolin @matextrem
@alongoni @shoom3301 @alfetopito @fairlighteth
[order table] Partial Fills table (BASE BRANCH) (#412)
230a3fe 
* Remove unused css

* add view fills button

* add TableHeading layout

* Update fills component

* Fix stories

* Small fix

* Fix percent formatting (#413)

* Fix error displaying 0% and 100%

* Add testing for formatting function

* Rmove helper function

* Style fixes for  Order fills page (#423)

* Refactoring to make the code unambiguous and reduced lines of code 38->12

* Fixed displaying of order assets info in <FilledProgress/>

* Fixed layout for FillsTable component

1. Added <TokenAmount> component for buy/sell/execution amounts. It helps to display them shorter
2. Fixed displaying of "View batch graph" button, it was too big for mobile view
3. Fixed global layout (in MainWrapper) to fix page with in mobile view. Warning! This change might brake smth in other pages

* Fixed filled progress width for DetailsTable in mobile view

* Execution price calculation for Fills table

* Added invert button for mobile layout

* isPriceInverted

* Execution time for trades table (#425)

* Execution time for trades table

* TradesTimestamps type

* Fix type

* Fix type

* Cache for fetchTradesTimestamps()

* Fixed blinking of fills table

isFirstLoading - seems to be excessive, because we should display loader only once at start and areTokensLoaded is enough

* Fixed lint errors and remove node version restriction

* Rollback node restriction

* Changed isLoading flag meaning in useOrderTrades()

Now it actually means isFirstLoading

* Fix lint errors (#426)

* Partial fills table/#437 fix fill or kill txhash (#438)

* Removed old placeholder

* Fixed txhash for fill or kill orders

* Do not mutate original obj

* Do not show fills tab for fill or kill orders (#439)

* Do not show fills tab for fill or kill orders

* Hide fills button

* Do not show fills tab for orders with single fills

* Do not show fills tab if there are no trades

* Moved fills button display logic to parent component

* Show tx hash for partial fills with single fill

* Updated label to be explicit about partial fills

* Fixed storybook

* Consistently using the same rule for displaying the fills tab, button and tx hash row:

When there are 2 trades or more, show fills tab and button, and hide tx hash row

* Do not show fills tab if there are no trades 🤦

* Partial fills table surplus (#440)

* Added new component SurplusComponent

* Added calculation for trade surplus getTradeSurplus

* Added surplus to fills table

* Refactored OrderSurplusDisplay to use SurplusComponent

* Fixed issue with surplus tooltip

* Removed buy amount value by mistake 😅

* Partial fills table adjust columns (#442)

* Inverted sell amount and buy amount positions on fills table

* Removed batch viewer link column from fills tab

* Moved surplus column to after buy amount on fills tab

* Added total surplus to fills table

* Removed `of <total amount>` from filled progress

* Partial fills table styling (#443)

* partial fills table styling

* partial fills table styling

* conditional lineBreak for filled amount

* Table header arrow wrap

* fix arrow green

* add surplus green icon to fills

* remove bottom border

* remove bottom border

* fix top padding sticky cards

* revert button wrapping

---------

Co-authored-by: fairlight <31534717+fairlighteth@users.noreply.github.com>

---------

Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>
Co-authored-by: Alexandr Kazachenko <shoom3301@gmail.com>
Co-authored-by: Alfetopito <alfetopito@users.noreply.github.com>
Co-authored-by: fairlight <31534717+fairlighteth@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Apr 14, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback

📖 Storybook ↗︎

@alfetopito alfetopito self-assigned this Apr 14, 2023
@alfetopito alfetopito requested review from a team April 14, 2023 14:39
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎

🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again.

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore playwright@1.32.2
  • @SocketSecurity ignore @fortawesome/fontawesome-common-types@6.4.0
  • @SocketSecurity ignore @fortawesome/fontawesome-svg-core@6.4.0
  • @SocketSecurity ignore @fortawesome/free-regular-svg-icons@6.1.2
  • @SocketSecurity ignore @fortawesome/free-solid-svg-icons@6.3.0
📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
playwright@1.32.2 (upgraded) install package.json
@fortawesome/fontawesome-common-types@6.4.0 (added) postinstall package.json via @fortawesome/fontawesome-svg-core@6.4.0, @fortawesome/react-fontawesome@0.2.0
@fortawesome/fontawesome-svg-core@6.4.0 (upgraded) postinstall package.json via @fortawesome/react-fontawesome@0.2.0
@fortawesome/free-regular-svg-icons@6.1.2 (added) postinstall package.json
@fortawesome/free-solid-svg-icons@6.3.0 (upgraded) postinstall package.json
Pull request alert summary
Issue Status
Install scripts ⚠️ 5 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@fortawesome/fontawesome-common-types@6.4.0 None +0 robmadole
⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@cowprotocol/cow-sdk@2.0.1 2.0.0-alpha.4...2.0.1 None +35/-0 cowprotocol_dev
@apollo/client@3.7.11 3.7.9...3.7.11 None +2/-3 apollo-bot
console-feed@3.5.0 3.4.3...3.5.0 None +0/-5 samdd
react-hot-loader@4.13.1 4.13.0...4.13.1 None +1/-2 kashey
react-inlinesvg@3.0.2 3.0.1...3.0.2 None +0/-0 gilbarbara
styled-components@5.3.9 5.3.6...5.3.9 None +1/-14 probablyup
babel-loader@8.3.0 8.2.3...8.3.0 filesystem +5/-23 nicolo-ribaudo
tslib@2.5.0 2.3.1...2.5.0 None +0/-0 typescript-bot
@popperjs/core@2.11.7 2.11.6...2.11.7 None +0/-0 fezvrasta
@babel/register@7.21.0 7.18.9...7.21.0 filesystem, environment +4/-22 nicolo-ribaudo
playwright@1.32.2 1.31.1...1.32.2 None +1/-1 aslushnikov
@fortawesome/fontawesome-svg-core@6.4.0 6.3.0...6.4.0 None +1/-0 robmadole
@types/react@16.14.38 16.14.35...16.14.38 None +0/-0 types
ethers@5.7.2 5.5.2...5.7.2 None +31/-30 ricmoo
@fortawesome/free-solid-svg-icons@6.3.0 6.1.2...6.3.0 None +0/-0 robmadole

🚮 Removed packages: @babel/core@7.20.12, @babel/plugin-transform-runtime@7.19.6, @babel/preset-env@7.20.2, prettier@2.8.2

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4700965687

  • 51 of 56 (91.07%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.3%) to 61.543%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/operator.ts 46 51 90.2%
Files with Coverage Reduction New Missed Lines %
src/utils/operator.ts 1 74.77%
Totals Coverage Status
Change from base Build 4562015077: 1.3%
Covered Lines: 872
Relevant Lines: 1231
💛 - Coveralls

@elena-zh
Copy link

elena-zh commented Apr 14, 2023 •
edited
Loading

Changes LGTM!
However, it would be great to address these issue in the next iteration:

Thanks!

@alfetopito alfetopito merged commit 49f7c2b into main Apr 14, 2023
@alfetopito alfetopito deleted the release/2.20.0 branch April 14, 2023 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

@anxolin anxolin anxolin approved these changes

Assignees

@alfetopito alfetopito

Labels
RELEASE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alfetopito @coveralls @elena-zh @anxolin @nenadV91 @shoom3301