-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
|
src/apps/explorer/components/SummaryCardsWidget/useGetSummaryData.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hey @ramirotw , shouldn't CoW Protocol volume card be updated as well? |
Maybe is an overkill, the daily volume is grouped by hour but then the rest is by day, we won't see any updates on the chart unless that timeframe is reached |
@ramirotw , So then maybe we should update a daily volume card once in an hour? |
As mentioned yesterday during our sync call, we won't update the graph automatically for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Why 30s? I think is not that bad if we query every 10s or so. Or on every block.
With 30s is possible we take almost a minute to update the latest settlement (if we are unlucky)
Also, something unrelated. Don't we plan to add a link to Etherscan (to the token). I think is nice for the meantime while we don't do a "token page"
@anxolin , in this PR you see a mocked table. Tokens table is implemented in #98 PR. So
it is implemented in #98
also is changed in #98 |
makes sense. I chose 30 as a starting point and to get some feedback. I'll update it to 10 |
Summary
Sets an interval to fetch the summary data each
3010 seconds