Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Update summary cards each 30 seconds #107

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

ramirotw
Copy link
Contributor

@ramirotw ramirotw commented Jun 3, 2022

Summary

Sets an interval to fetch the summary data each 30 10 seconds

@ramirotw ramirotw requested review from alfetopito and matextrem June 3, 2022 12:32
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elena-zh
Copy link

elena-zh commented Jun 7, 2022

Hey @ramirotw , shouldn't CoW Protocol volume card be updated as well?

@ramirotw
Copy link
Contributor Author

ramirotw commented Jun 7, 2022

Hey @ramirotw , shouldn't CoW Protocol volume card be updated as well?

Maybe is an overkill, the daily volume is grouped by hour but then the rest is by day, we won't see any updates on the chart unless that timeframe is reached

@elena-zh
Copy link

elena-zh commented Jun 7, 2022

@ramirotw , So then maybe we should update a daily volume card once in an hour?
@alfetopito , WDYT?

@alfetopito
Copy link
Collaborator

As mentioned yesterday during our sync call, we won't update the graph automatically for now

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Why 30s? I think is not that bad if we query every 10s or so. Or on every block.
With 30s is possible we take almost a minute to update the latest settlement (if we are unlucky)

Also, something unrelated. Don't we plan to add a link to Etherscan (to the token). I think is nice for the meantime while we don't do a "token page"

@anxolin
Copy link
Contributor

anxolin commented Jun 8, 2022

Question, why there's so many WETH?
image

@elena-zh
Copy link

elena-zh commented Jun 8, 2022

@anxolin , in this PR you see a mocked table. Tokens table is implemented in #98 PR. So

Also, something unrelated. Don't we plan to add a link to Etherscan (to the token). I think is nice for the meantime while we don't do a "token page"

it is implemented in #98

Question, why there's so many WETH?

also is changed in #98

@ramirotw
Copy link
Contributor Author

ramirotw commented Jun 8, 2022

Why 30s? I think is not that bad if we query every 10s or so. Or on every block.
With 30s is possible we take almost a minute to update the latest settlement (if we are unlucky)

makes sense. I chose 30 as a starting point and to get some feedback. I'll update it to 10

@ramirotw ramirotw merged commit 27526e7 into 35-epic-home-page Jun 8, 2022
@ramirotw ramirotw deleted the ramirotw/batch-id-interval branch June 8, 2022 11:17
@henrypalacios henrypalacios mentioned this pull request Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants