This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
Handle error when Barn is down #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
approved these changes
Mar 29, 2023
alfetopito
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
I was going to suggest to use Promise.allSettled but your way is more explicitly handling barn failures and letting prod failures pop up as intended
nenadV91
approved these changes
Mar 29, 2023
elena-zh
approved these changes
Mar 29, 2023
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds some resilience in case BARN is down (which is more fragile and less important than PROD)
In case Barn is down, it will just show PROD data.
Context
https://cowservices.slack.com/archives/C0361CDD1FZ/p1680083877919069?thread_ts=1680081047.924569&cid=C0361CDD1FZ
Technical comment
I took the opportunity of this change to not use 2 SDKs, only one is needed (since we can pass the environment each time)
To Test
**TEST BOTH BARN & PROD orders/trades are displayed in the explorer.
We cannot make it fail right now to test it work, so i will just make another PR making BARN to fail on porpouse to verify that it still shows the PROD data