Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

fix: view fills button on details page nagivates to fills tab #455

Merged
merged 1 commit into from
Apr 21, 2023
Merged

fix: view fills button on details page nagivates to fills tab #455

merged 1 commit into from
Apr 21, 2023

Conversation

alfetopito
Copy link
Collaborator

Summary

Closes #444

Fills button on details page works!

Screen.Recording.2023-04-20.at.17.51.05.mov

To Test

  1. Load an order with multiple fills such as 0x4a3927813f512fcc6ba710ee44d2a9204d21e997c5c122a60d1d4a2106fdd848042b32ac6b453485e357938bdc38e0340d4b927661c2639b
  2. Click on the View fills button
  • Should move to fills tab and load the data
  1. Change to overview tab
  2. Click on fills tab on top
  • Should move to fills tab and load the data

@alfetopito alfetopito self-assigned this Apr 20, 2023
@vercel
Copy link

vercel bot commented Apr 20, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback

📖 Storybook ↗︎

@alfetopito alfetopito requested review from a team April 20, 2023 16:54
@github-actions
Copy link

Pull Request Test Coverage Report for Build 4756859826

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.543%
Totals Coverage Status
Change from base Build 4754407309: 0.0%
Covered Lines: 872
Relevant Lines: 1231
💛 - Coveralls

elena-zh
elena-zh approved these changes Apr 21, 2023
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@alfetopito alfetopito merged commit d8238c8 into develop Apr 21, 2023
@alfetopito alfetopito deleted the 444/fills-button-navigation branch April 21, 2023 14:45
@nenadV91 nenadV91 mentioned this pull request May 4, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

@anxolin anxolin anxolin approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.20]View fills tab is not loaded
3 participants
@alfetopito @anxolin @elena-zh