Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

fix: show only trades belonging to the current page on fills tab #456

Merged
merged 2 commits into from
May 2, 2023
Merged

fix: show only trades belonging to the current page on fills tab #456

merged 2 commits into from
May 2, 2023

Conversation

alfetopito
Copy link
Collaborator

Summary

Closes #445

Fills tab list shows only trades from the current page

To Test

  1. Load an order with >10 trades, such as 0x9f5f18111f22b1912bd8f291b753a6fd85e04cd9f05111520f6108fc052716279fa3c00a92ec5f96b1ad2527ab41b3932efeda58643ff3da
  2. Go to fills tab
  • It should show more than 1 page
    image
  • The list should be limited by default to 10 items
  • There should be 10 rows in the table
  1. Go to the next page
  • It should show the next trades, up to 10 in the page

@alfetopito alfetopito self-assigned this Apr 21, 2023
@vercel
Copy link

vercel bot commented Apr 21, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback

📖 Storybook ↗︎

@alfetopito alfetopito requested review from a team April 21, 2023 15:36
@alfetopito alfetopito changed the title Filter out only trades belonging to the current page fix: show only trades belonging to the current page on fills tab Apr 21, 2023
@coveralls
Copy link

coveralls commented Apr 21, 2023 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 4861704073

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.543%
Totals Coverage Status
Change from base Build 4766062423: 0.0%
Covered Lines: 872
Relevant Lines: 1231
💛 - Coveralls

elena-zh
elena-zh approved these changes Apr 21, 2023
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

anxolin
anxolin reviewed Apr 28, 2023
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/components/orders/OrderDetails/FillsTable.tsx Outdated Show resolved Hide resolved
@alfetopito alfetopito merged commit 0224071 into develop May 2, 2023
@alfetopito alfetopito deleted the 445/fills-tab-pagination branch May 2, 2023 13:21
@nenadV91 nenadV91 mentioned this pull request May 4, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin left review comments

@elena-zh elena-zh elena-zh approved these changes

@shoom3301 shoom3301 shoom3301 approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.20]Pagination is not correct on the Fills tab
5 participants
@alfetopito @coveralls @anxolin @shoom3301 @elena-zh