-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
|
…o 37-volume-chart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great Henry! Quite a lot of code.
It's fine by me, just asked @fairlighteth for a review too as he's better equipped with the CSS bits.
src/apps/explorer/components/SummaryCardsWidget/VolumeChart.tsx
Outdated
Show resolved
Hide resolved
Thank you for this PR. Here some comments:
|
src/apps/explorer/components/SummaryCardsWidget/VolumeChart.styled.ts
Outdated
Show resolved
Hide resolved
src/apps/explorer/components/SummaryCardsWidget/VolumeChart.styled.ts
Outdated
Show resolved
Hide resolved
Hey @henrypalacios , great job!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
Regarding the code review, I'm still trying to understand everything, will probably comment later.
Regarding the functional part there are two things I'd like to comment:
- Shouldn't the graph color be green here instead of red? From my understanding if the first value of the selected period is $264 and the last $10.267.230 the trend is positive not negative.
|
Thank you for you time @fairlighteth,
It is no possible yet because the data is not available in the graph.
Done!
@alongoni will work on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
@elena-zh could you please check again 🙏? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @henrypalacios , @alongoni , changes LGTM!
I have created 2 related low-priority issues:
- iOS: Numbers look like broken ones when move the volume chart line #76
- Make volume chart auto-adjustable when changing a screen width #75
Besides, I would update the cards each time when I change a network. However, it must be fixed in another PR.
Thanks
Summary
Closes #37
Proposal:
Create a graph component
VolumeChart
to display the volume using lightweight-chartCreate a component
VolumeChartWidget
for data request logic, change of time periodicity.Simulate a query with data and response close to the future implementation.
To Test