-
Notifications
You must be signed in to change notification settings - Fork 8
Add a copy button and navigation to the last batch #68
Conversation
|
Hey @alongoni , nice changes! I know that the PR is still WIP, so maybe I could add some ideas how to make Batch id look better in a mobile view.. Also, in order to avoid moving 'copied' to the next line in a mobile view, could we remove 'copied' word, and live just a tick as a 'confirmed' action. WDYT? Thanks! |
Hey @alongoni , great job! Just a tine nitpick: when the 'tick' icon is changed to the 'copy' icon, it is still in a green color for a sec. See the video: https://watch.screencastify.com/v/9GakrtOeiqmaSZyMql9g Can we fix it somehow? Thanks! |
Hey @alongoni , another nitpick: now the 'Copied' is clued to the batch ID |
I have connected #12 issue to this PR as it fixes the issue. |
hey @elena-zh can you test it again please? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alongoni , LGTM now!
Summary
Closes #66
Extra changes: