Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Add a copy button and navigation to the last batch #68

Merged
merged 10 commits into from
Apr 22, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Apr 18, 2022

Summary

Closes #66
image
Extra changes:

  • Address format with 6 + 4 digits 0x0003...e29c (according format in others sections.)
  • Improvements to the Copy button tooltip. Now the "Copied" message appears as a tooltip (texts moving prevented).
    image

@alongoni alongoni self-assigned this Apr 18, 2022
@github-actions
Copy link

@elena-zh
Copy link

elena-zh commented Apr 20, 2022

Hey @alongoni , nice changes!

I know that the PR is still WIP, so maybe I could add some ideas how to make Batch id look better in a mobile view..
So maybe we could reduce an ID font size when showing it in a mobile view?
image

Also, in order to avoid moving 'copied' to the next line in a mobile view, could we remove 'copied' word, and live just a tick as a 'confirmed' action. WDYT?
image

Thanks!

@alongoni alongoni marked this pull request as ready for review April 20, 2022 23:34
@elena-zh
Copy link

Hey @alongoni , great job!

Just a tine nitpick: when the 'tick' icon is changed to the 'copy' icon, it is still in a green color for a sec.
image

See the video: https://watch.screencastify.com/v/9GakrtOeiqmaSZyMql9g

Can we fix it somehow?
However, if it takes a lot of effort, we can go live with the current implementation.

Thanks!

@alongoni alongoni requested a review from elena-zh April 21, 2022 12:27
@elena-zh
Copy link

Hey @alongoni , another nitpick: now the 'Copied' is clued to the batch ID
image

@elena-zh
Copy link

I have connected #12 issue to this PR as it fixes the issue.

@alongoni
Copy link
Contributor Author

hey @elena-zh can you test it again please? Thanks!

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alongoni , LGTM now!

@alongoni alongoni merged commit d406fba into 35-epic-home-page Apr 22, 2022
@alongoni alongoni deleted the 66-copy-btn-batch-id branch April 22, 2022 15:56
@henrypalacios henrypalacios mentioned this pull request Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants