Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Volume chart and cards layout #90

Merged
merged 12 commits into from
May 19, 2022
Merged

Volume chart and cards layout #90

merged 12 commits into from
May 19, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented May 12, 2022

Summary

Closes #87

image
image

@alongoni alongoni self-assigned this May 12, 2022
@alongoni alongoni changed the title change volume chart and cards layout Volume chart and cards layout May 12, 2022
@alongoni alongoni mentioned this pull request May 12, 2022
5 tasks
@github-actions
Copy link

@alongoni alongoni marked this pull request as ready for review May 13, 2022 20:25
@elena-zh
Copy link

Hey @alongoni , great changes! The page layout looks much0much better now!

However, some nitpicks from my side:

  1. Seems like cards area does not 100% correspond to the Top tokens table area. Can we fix it somehow?
    not 100% aligned
    aligned2
  2. 'Volume' in the card should be started with an upper-case letter if follow all the rest cards logic:
    volume
  3. AFAIU, Total volume card's value is not integrated in this PR. Should I create a task for this?

Thanks!

@alfetopito
Copy link
Collaborator

Oh yes, it does look very nice, love how it expands on bigger screens

Small screen view is a bit too wide IMO.
I can understand the graph to remain larger, but I think the cards should shrink like the table

Screen.Recording.2022-05-16.at.13.52.36.mov

@alongoni
Copy link
Contributor Author

I can understand the graph to remain larger, but I think the cards should shrink like the table

Thanks @alfetopito! We will be working on this issue on #75

Copy link
Contributor

@ramirotw ramirotw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@elena-zh
Copy link

@alongoni , great!

However, a nitpick: I still can see a mismatch in sections' boarders for some devices. See how sections look like in 'Surface Duo' device
duo 2
surface duo

Could you please fix it?

Thanks!

@elena-zh
Copy link

Hey @alongoni ,now the page in small resolutions looks great.
However, now I see not fully filled in chart in big screen resolutions.
huge screen

Besides, the page elements are resizing when I change chart periods. See the video: https://watch.screencastify.com/v/XY6AEwulClRA5NMykWzu

@ramirotw ramirotw self-requested a review May 19, 2022 11:27
@ramirotw
Copy link
Contributor

@alongoni I have updated the branch and resolved conflicts. Apart from what @elena-zh mentioned, there are many console log errors
image

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

Copy link
Contributor

@ramirotw ramirotw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants