Driver settle queue tests #3133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
force-pushed
the
driver-settle-queue-tests
branch
from
287ccc1
to
5b27c13
Compare
squadgazzz
force-pushed
the
driver-settle-queue-tests
branch
from
a5ab68a
to
7bcd92f
Compare
squadgazzz
commented
Nov 22, 2024
Comment on lines
+132
to
+135
| let id1 = test.solve().await.ok().id(); | ||
| let id2 = test.solve().await.ok().id(); | ||
| let id3 = test.solve().await.ok().id(); | ||
| let id4 = test.solve().await.ok().id(); |
There was a problem hiding this comment.
Due to the framework limitations, this has to be executed sequentially. Otherwise, each solution will most likely receive the same ID, which is critical for this test, where at least 4 distinct settlement requests must be sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An attempt to properly test #3129. The idea is to send multiple
/settlerequests to the same driver to check that some will be discarded due to the settlement queue limit. To achieve that, I found the easiest way to introduce some delay in the settlement process on the driver's side by using the existing ethrpc batch delay, which is used to wait for a certain amount of time before sending the call to accumulate a batch.It turned out, that this config was hardcoded, so it was required to enable it in the arguments first to use properly in tests.
Changes
Important
ethrpc_max_batch_size = 20must be added to the Driver's infra config since the default value is100, which is currently used by other components. And only Driver uses20. https://github.com/cowprotocol/infrastructure/pull/2301How to test
This is the test.