Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Review Prometheus metrics and add additional ones #78

Closed
anxolin opened this issue Oct 3, 2023 · 1 comment
Closed

chore: Review Prometheus metrics and add additional ones #78

anxolin opened this issue Oct 3, 2023 · 1 comment
Assignees
@anxolin
Labels
E:1.2: Watch Tower Service https://github.com/cowprotocol/pm/issues/8

Comments

@anxolin
Copy link
Contributor

anxolin commented Oct 3, 2023

Background

Review metrics, and reiterate the initial proposal.
@anxolin anxolin self-assigned this Oct 3, 2023
@mfw78 mfw78 mentioned this issue Oct 6, 2023
Merged
2 tasks
@mfw78 mfw78 linked a pull request Oct 9, 2023 that will close this issue
chore: metrics todo and naming #95
Merged
2 tasks
@mfw78 mfw78 removed a link to a pull request Oct 9, 2023
chore: metrics todo and naming #95
Merged
2 tasks
mfw78 added a commit that referenced this issue Oct 10, 2023
@mfw78
chore: metrics todo and naming (#95)
412192a 
# Description
This PR addresses issues around naming conventions for the prometheus
metrics. Best efforts have been followed to adhere to [best
practices](https://prometheus.io/docs/practices/naming/).

# Changes

- [x] Revised metric naming and labeling to be in accordance with best
practices.
- [x] Removed custom API prometheus metrics and replaced with
middleware.

## How to test

1. Run a sync from contract genesis.
2. Observe via `http://127.0.0.1:8080/metrics` there respective metrics
changing.

## Related Issues

Related #78, #70
@mfw78
Copy link
Contributor

mfw78 commented Oct 10, 2023

Fixed in #100

@mfw78 mfw78 added the E:1.2: Watch Tower Service https://github.com/cowprotocol/pm/issues/8 label Oct 10, 2023
@mfw78 mfw78 closed this as completed Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anxolin anxolin

Labels
E:1.2: Watch Tower Service https://github.com/cowprotocol/pm/issues/8
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anxolin @mfw78