bug: low level calls cause log spamming if not adhering to the interface #91
Labels
bug
Something isn't working
E:1.2: Watch Tower Service
https://github.com/cowprotocol/pm/issues/8
Problem
When the watch tower polls a custom order type, the selector / revert error returned has no guarantee of being compliant with the interface. It's currently being observed that old TWAP orders from the pre-production version of the contracts are returning
OrderNotValid()
selectors, as opposed toOrderNotValid(string)
which is causing these to not be recognised by the low-level call handlers.Impact
Causes needless log spamming, and doesn't promote strict interface adherence.
To reproduce
Expected behaviour
If an order doesn't adhere to the interface, it should not be monitored. Any order that doesn't return a known custom error for the revert should be dropped immediately.
Screenshots/logs
In this case,
0xf3ec7a9f
corresponds to the previousOrderNotValid()
selector prior to the insertion of thestring
for there reason (implemented just before push to production).Tenderly watch-tower version/commit hash
Version:
v1.0.1-rc.0
The text was updated successfully, but these errors were encountered: