Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: api and version polish #92

Merged
merged 3 commits into from
Oct 6, 2023
Merged

chore: api and version polish #92

merged 3 commits into from
Oct 6, 2023

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Oct 5, 2023

Description

This PR applies some fixes / feedback from previous PRs.

Changes

  • All versioning within the repository now refers to package.json.
  • /about endpoint moved to /version endpoint to align with services repo.
  • DRY'd the run command.
  • Rest API object only created if it's intended to be used.

How to test

  1. Run yarn ts-node ./src/index.ts run --rpc http://10.23.0.2:8545 --rpc http://10.23.0.2:8645 --deployment-block 17883049 --deployment-block 29389123 --page-size 10000 and observe synchronisation.

NOTE: Substitute your RPCs in the above.

Related Issues

Related #89

@mfw78 mfw78 added enhancement New feature or request E:1.2: Watch Tower Service https://github.com/cowprotocol/pm/issues/8 labels Oct 5, 2023
@mfw78 mfw78 self-assigned this Oct 5, 2023
@mfw78 mfw78 mentioned this pull request Oct 6, 2023
src/commands/run.ts Outdated Show resolved Hide resolved
src/types/index.ts Show resolved Hide resolved
src/utils/api.ts Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
@mfw78 mfw78 requested a review from anxolin October 6, 2023 11:58
@mfw78 mfw78 merged commit fd88b3f into main Oct 6, 2023
3 checks passed
@mfw78 mfw78 deleted the api-polish branch October 6, 2023 22:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E:1.2: Watch Tower Service https://github.com/cowprotocol/pm/issues/8 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants