Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configurable watchdog timeout #93

Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix: configurable watchdog timeout #93

merged 2 commits into from
Oct 6, 2023

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Oct 5, 2023

Description

Some chains aren't created equal, so having a constant watch dog timeout for the block watcher isn't suitable.

Changes

  • Add user-configurable watch-dog timeout for the block watcher.
  • Some gardening to unify around integer type assertions for CLI options (NOTE: deploymentBlock not considered for integer assertions).

How to test

  1. Attempt to run with a non-integer option value that should be an integer. Observe failure to start.
  2. Start with --watchdog-timeout flag set to non-default value, such as 120, and observe block watcher running with a 120s timeout.

Related Issues

Fixes #85

@mfw78 mfw78 added the bug Something isn't working label Oct 5, 2023
@mfw78 mfw78 requested review from anxolin, ahhda and a team October 5, 2023 06:33
@mfw78 mfw78 self-assigned this Oct 5, 2023
@mfw78 mfw78 linked an issue Oct 5, 2023 that may be closed by this pull request
@mfw78 mfw78 force-pushed the fix-watch-dog-timeout branch from 30c8d59 to f994854 Compare October 6, 2023 01:45
src/domain/chainContext.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
@mfw78 mfw78 force-pushed the fix-watch-dog-timeout branch from f994854 to 88b4088 Compare October 6, 2023 11:59
Base automatically changed from api-polish to main October 6, 2023 22:11
@mfw78 mfw78 force-pushed the fix-watch-dog-timeout branch from cc5126c to ea88ecc Compare October 6, 2023 22:26
@mfw78 mfw78 merged commit 1f7def4 into main Oct 6, 2023
3 checks passed
@mfw78 mfw78 deleted the fix-watch-dog-timeout branch October 6, 2023 22:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: watch dog timing out on goerli
3 participants