Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Convert replicaton tests to the v1 API #116

Merged

Conversation

freeekanayaka
Copy link
Member

These tests now only use the v1 API and the associated test cluster machinery.

@freeekanayaka freeekanayaka added the downstream Trigger downstream tests label Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (72b4804) 75.58% compared to head (1bad892) 75.50%.

Files Patch % Lines
src/replication.c 7.14% 3 Missing and 10 partials ⚠️
src/convert.c 52.38% 8 Missing and 2 partials ⚠️
src/election.c 54.54% 4 Missing and 6 partials ⚠️
src/client.c 22.22% 4 Missing and 3 partials ⚠️
src/message.c 73.68% 2 Missing and 3 partials ⚠️
src/membership.c 0.00% 1 Missing and 2 partials ⚠️
src/recv_append_entries_result.c 0.00% 0 Missing and 3 partials ⚠️
src/recv_request_vote_result.c 0.00% 2 Missing and 1 partial ⚠️
src/tick.c 0.00% 0 Missing and 3 partials ⚠️
src/recv_append_entries.c 0.00% 0 Missing and 2 partials ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   75.58%   75.50%   -0.09%     
==========================================
  Files          52       52              
  Lines        9635     9614      -21     
  Branches     2376     2348      -28     
==========================================
- Hits         7283     7259      -24     
- Misses       1035     1063      +28     
+ Partials     1317     1292      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@freeekanayaka freeekanayaka force-pushed the convert-replicaton-tests-to-v1 branch 11 times, most recently from 64ea220 to 6b013ab Compare December 28, 2023 10:23
freeekanayaka and others added 17 commits December 28, 2023 12:44
When restoring entries from loaded persisted state, any second-to-last
configuration entry in the log must have been committed, because we don't allow
multiple uncommitted configuration changes. In that case update the commit index
accordingly.

Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
This violates Raft assumptions and could leave to double votes.

Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka freeekanayaka force-pushed the convert-replicaton-tests-to-v1 branch from d4d686e to 5faccda Compare December 28, 2023 12:48
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka freeekanayaka force-pushed the convert-replicaton-tests-to-v1 branch 3 times, most recently from 04bd55e to 1bad892 Compare December 28, 2023 16:12
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka freeekanayaka merged commit 6577440 into cowsql:main Dec 28, 2023
40 of 42 checks passed
@freeekanayaka freeekanayaka deleted the convert-replicaton-tests-to-v1 branch December 28, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downstream Trigger downstream tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant