Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: Fix coverage target when using lcov 2.0 #119

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

freeekanayaka
Copy link
Member

The lcov 2.0 release has some backward-incompatible changes, make it ignore warnings for now.

The lcov 2.0 release has some backward-incompatible changes, make it ignore
warnings for now.

Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6577440) 75.50% compared to head (daf31c4) 75.51%.

Files Patch % Lines
src/raft.c 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   75.50%   75.51%   +0.01%     
==========================================
  Files          52       52              
  Lines        9614     9619       +5     
  Branches     2348     2348              
==========================================
+ Hits         7259     7264       +5     
  Misses       1063     1063              
  Partials     1292     1292              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@freeekanayaka freeekanayaka merged commit fd63a69 into cowsql:main Dec 28, 2023
9 checks passed
@freeekanayaka freeekanayaka deleted the support-lcov-v2 branch December 29, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant