Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1: Drop status field from RAFT_PERSISTED_SNAPSHOT #159

Merged

Conversation

freeekanayaka
Copy link
Member

No description provided.

@freeekanayaka freeekanayaka added the downstream Trigger downstream tests label Feb 3, 2024
@freeekanayaka freeekanayaka changed the title replication: Drop redundant reset of r->snapshot.persisting v1: Drop status field from RAFT_PERSISTED_SNAPSHOT Feb 3, 2024
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b9ea8c5) 74.22% compared to head (a49ceb3) 74.11%.

Files Patch % Lines
src/legacy.c 0.00% 1 Missing and 1 partial ⚠️
src/replication.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   74.22%   74.11%   -0.11%     
==========================================
  Files          52       52              
  Lines       10322    10320       -2     
  Branches     2474     2473       -1     
==========================================
- Hits         7661     7649      -12     
- Misses       1293     1303      +10     
  Partials     1368     1368              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@freeekanayaka freeekanayaka force-pushed the drop-persisted-snapshot-status branch 6 times, most recently from 97ff665 to a49ceb3 Compare February 3, 2024 21:56
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
We'll fill it when we need to wait for a snapshot being taken to complete.

Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka freeekanayaka merged commit f742c08 into cowsql:main Feb 3, 2024
40 of 42 checks passed
@freeekanayaka freeekanayaka deleted the drop-persisted-snapshot-status branch February 3, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downstream Trigger downstream tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant