Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

legacy: Remove redundant logic already contained in raft_step() #160

Merged
merged 12 commits into from
Feb 3, 2024
Merged

legacy: Remove redundant logic already contained in raft_step() #160

merged 12 commits into from
Feb 3, 2024

Conversation

freeekanayaka
Copy link
Member

No description provided.

@freeekanayaka
legacy: Assert that no snapshot is being installed when taking one
40b5468 
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka
legacy: Remove unnecessary set of snapshot.persisting
83c3ddf 
When we take a snapshot, we're already using the snapshot.taking flag.

Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka
legacy: Remove unnecessary check of last snapshot entry
2f95ffb 
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka
legacy: Move r->snapshot.taking field to r->legacy.snapshot_taking
ebca666 
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka
legacy: No need for LegacyLeadershipTransferInit to be public
a3b5b53 
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka
legacy: Initialize transfer request after raft_step() is called
3cbdaa1 
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka
legacy: Remove duplicated logic in raft_step() and raft_transfer()
0e17764 
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka
client: Make clientSelectTransferee private
cc98f9f 
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka
legacy: Remove duplicated logic in raft_step() and raft_add()
5fd6b58 
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2024 •
edited
Loading

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (ba7d647) 73.95% compared to head (7129763) 74.28%.

Files Patch % Lines
src/legacy.c 43.75% 3 Missing and 6 partials ⚠️
src/raft.c 75.00% 0 Missing and 2 partials ⚠️
src/replication.c 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   73.95%   74.28%   +0.32%     
==========================================
  Files          52       52              
  Lines       10215    10180      -35     
  Branches     2460     2442      -18     
==========================================
+ Hits         7555     7562       +7     
+ Misses       1299     1265      -34     
+ Partials     1361     1353       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@freeekanayaka freeekanayaka added the downstream Trigger downstream tests label Feb 3, 2024
@freeekanayaka
legacy: Don't set r->now directly
cf86c7d 
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka
raft.h: Add raft_match_index() returning the match index of a server
1095649 
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka
legacy: Use raft_match_index() instead of internal functions
7129763 
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
@freeekanayaka freeekanayaka merged commit 6cd2c84 into cowsql:main Feb 3, 2024
41 of 42 checks passed
@freeekanayaka freeekanayaka deleted the remove-redundant-legacy-logic branch February 3, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
downstream Trigger downstream tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@freeekanayaka