v1: Use TaskSendMessage() to send messages #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the code enqueue a `struct raft_task` object instead of calling out to the legacy `struct raft_io` interface. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
This makes the code enqueue a `struct raft_task` object instead of calling out to the legacy `struct raft_io` interface. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
This commit covers the case in which the message is sent asynchronously after entries have been persisted. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
The sendAppendEntriesCb() raft_io->send() callback has been renamed to replicationSendAppendEntriesDone(), which gets called when raft_step() handles the completion of a RAFT_SEND_MESSAGE task for an AppendEntries message. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 74.79% 74.88% +0.08%
==========================================
Files 53 53
Lines 9194 9142 -52
Branches 2296 2279 -17
==========================================
- Hits 6877 6846 -31
+ Misses 1017 1005 -12
+ Partials 1300 1291 -9
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the code to use the
TaskSendMessage()helper to queue aRAFT_SEND_MESSAGEtask, instead of calling out to the legacyraft_io->send()interface.