v1: Use TaskPersistSnapshot() instead of raft_io->snapshot_put() #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This structure will eventually replace struct raft_snapshot, since actual snapshot data will be completely managed by consumer code. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
This structure holds parameters for RAFT_PERSIST_SNAPSHOT tasks. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
It enqueues new RAFT_PERSIST_SNAPSHOT tasks. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Use raft_io->snapshot_put() to handle RAFT_PERSIST_SNAPSHOT tasks. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Update the code to enqueue a RAFT_PERSIST_SNAPSHOT task instead of calling out the legacy raft_io->snapshot_put() interface. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 74.92% 74.93% +0.01%
==========================================
Files 53 53
Lines 9215 9265 +50
Branches 2285 2291 +6
==========================================
+ Hits 6904 6943 +39
- Misses 1009 1015 +6
- Partials 1302 1307 +5
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the code to enqueue a
RAFT_PERSIST_SNAPSHOTtask instead of calling out the legacyraft_io->snapshot_put()interface.