fix: Querying all trips from all accounts #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JF-Cozy
approved these changes
Feb 8, 2024
BundleMonUnchanged files (4)
Total files change +5B 0% Final result: ✅ View report in BundleMon website ➡️ |
paultranvan
reviewed
Feb 8, 2024
| { endDate: 'desc' } | ||
| ]) | ||
| .select(['startDate', 'endDate', 'title', 'aggregation']) | ||
| .indexFields(['startDate', 'endDate']) |
There was a problem hiding this comment.
The endDate does not seem necessary ? I guess the sort on startDate is enough
There was a problem hiding this comment.
It's necessary to have the endDate in the app(for duration trip calculations at least), but indeed it is not useful in the .sortBy
There was a problem hiding this comment.
And if it's not useful in the sortBy, it's not useful in the indexField either ;)
There was a problem hiding this comment.
Seen together, pending the correction of this issue cozy/cozy-client#1216, endDate cannot be removed from the indexFields
Merkur39
force-pushed
the
fix/ver-119
branch
2 times, most recently
from
fb98b25 to
d90cb14
Compare
paultranvan
approved these changes
Feb 8, 2024
This query should not sort the accounts, because since there is a limitBy we can run into a case where we don't see all the latest trips. The presence in the .select is not necessary either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query should not sort the accounts, because since there is a limitBy, we can run into a case where we don't see all the latest trips.
The presence in the .select is not necessary either.