Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default value from DOM #728

Open
Crash-- opened this issue Jul 5, 2021 · 0 comments
Open

Remove default value from DOM #728

Crash-- opened this issue Jul 5, 2021 · 0 comments

Comments

@Crash--
Copy link
Contributor

Crash-- commented Jul 5, 2021

We now have a new method to init and inject the cozy-stack variables in the app's dom. We use cozy-data={{}} instead of cozy-data-X={}. By doing so, we can break the bar if the app doesn't pass all the value during the initialization phase of the bar.

I think we should remove the fact that the Bar can init itself from the DOM. The APP should be responsible to do that.

We should remove https://github.com/cozy/cozy-bar/blob/master/src/dom.js#L4 for instance.

appNamePrefix = getAppNamePrefix(),
we should not set default value.

(see cozy/cozy-drive#2395)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant