fix: Pass the right arguments to the cozy-bar #2395
Conversation
We decided to use data-cozy={{}} to get access to
the variables injected by the cozy-stack.
By removing data-cozy-*, cozy-bar was lost since
the bar will look into cozy-data-appslug to detect
the slug of the app. Since the bar can't do that
anymore, we need to pass all the args during the
init phase.
|
Est-ce qu'il ne faudrait pas plutôt patcher cozy-bar dans ce cas ? Sinon ça voudrait dire qu'on a le souci pour toutes les app non ? |
We can patch the bar. But in fact, I prefer having an explicit initialization of the cozy-bar. Relying on a data-structure that we don't manage is very... dangerous. |
C'est à dire ? Je pense qu'une petite issue pour corriger |
L'idée étant de supprimer ces défaults et d'obliger l'app qui consomme la bar à initialiser tout ce qu'il faut. Explicit is way better than implicit in that case. |
We decided to use data-cozy={{}} to get access to
the variables injected by the cozy-stack.
By removing data-cozy-*, cozy-bar was lost since
the bar will look into cozy-data-appslug to detect
the slug of the app. Since the bar can't do that
anymore, we need to pass all the args during the
init phase.