feat(permissionColl & models/sharing): Improve sharing link feature #1579
+183
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merkur39
force-pushed
the
feat/vo-1244
branch
from
3800ef7 to
029300d
Compare
2 tasks
JF-Cozy
approved these changes
Jan 20, 2025
paultranvan
approved these changes
Jan 20, 2025
BREAKING CHANGE: By default, the name of the attribute returned
via `createSharingLink` is no longer `email` but `code`.
You can either adapt your code accordingly or
simply add the option `{ codes: 'email' }` when calling `createSharingLink`.
BREAKING CHANGE: Rename getSharingLink to makeSharingLink. This function creates or updates a share link.
Add an option parameter to manage the validity date and password of the permission.
Merkur39
force-pushed
the
feat/vo-1244
branch
from
029300d to
d8a7e03
Compare
paultranvan
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall improvement in link sharing
Link with : cozy/cozy-stack#4506