This repository has been archived by the owner on Jul 31, 2018. It is now read-only.
Just clean some code #208
Merged
Just clean some code #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the javascript one.
|
Travis build is red but it seems it's not related to this PR but it's from before. I can see that #207 has already a red build. |
| newPwd = cryptoTools.encrypt slaveKey, password | ||
| return newPwd | ||
| else | ||
| sendMail() | ||
| err = new Error "master key and slave key don't exist" | ||
| err = new Error "slave key does not exist" |
There was a problem hiding this comment.
doesn't is better than does not.
nono
force-pushed
the
update-password
branch
from
35e980a
to
2bbc920
Compare
|
Well, I think it's coming from the release of node 0.10.42 and the upgrade of http-parser: https://nodejs.org/en/blog/release/v0.10.42/ |
nono
force-pushed
the
update-password
branch
from
2bbc920
to
c528356
Compare
|
There were two fixes for http-parser: one for node 0.10 and one for node 0.12. I really hope that the next versions of node 0.10 & 0.12 will fix our travis build. |
|
And the build is green! New versions of node 0.10 and node 0.12 have been released (with a fix for http-parser), I've relaunched the build for them and it works. This PR can be reviewed/merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.